I'm not sure about the isRevertRedirectSetting, but a getter and setter
on the RequestOptions is good. I've just checked in that change to trunk
- James
herbert wrote:
> Hi Chris!
>
> My solution would be adding a property followRedirects to the class
> RequestOptions.
>
> Next change would be in the method createMethod() of the class MethodHelper.
> After creation of the concrete HTTP-Method I would insert the following
> line:
> httpMethod.setFollowRedirects(options.isFollowRedirect());
>
> (Or another version, introducing a property revertRedirectSetting to the
> class
> RequestOptions. And then in createMethod():
>
> if (options.isRevertRedirectSetting()) {
> httpMethod.setFollowRedirects(!httpMethod.getFollowRedirects());
> })
>
> Dunno, if these are generic approaches, that are interesting for others?
>
> Regards, Herbert
>
>
> Chris Berry wrote:
>> Herbert,
>> I think you're correct. I just *assumed* that this was a part of
>> HttpMethodParams. But I cannot see it there either (at least with a
>> cursory look)
>>
>> I think you should simply make the enclosed HttpClient protected in
>> AbderaClient. And then extend AbderaClient locally with
>> MyAbderaClient. This is probably a better solution than actually
>> adding an accessor for HttpClient in AbderaClient, which seems a bit
>> promiscuous to me.
>> Cheers,
>> -- Chris
>>
>>
>
