Layout units was introduced so we could have true WYSIWYG display. Unfortunately it means there is a lot of duplication in the formatting logic. You will find all through out there are things like m_iWidth and m_iWidthInLayoutUntis, etc. This, I think, does need to be looked at at some stage. I originally tried to have one coordinate system but found it too difficult at the time to keep track of what units were at layout resolution and which were at screen resolution. The calculation of tabs in layout units still has to be completed as shown in the following bug. http://www.abisource.com/bugzilla/show_bug.cgi?id=475 > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]]On Behalf Of Matt Kraai > Sent: Friday, 14 April, 2000 01:27 > To: AbiWord Developers > Subject: layout units > > > Howdy, > > In abi/src/text/fmt/xp/fl_BlockLayout.cpp, there are almost identical > functions findNextTabStop and findNextTabStopInLayoutUnits. In > fp_Line.cpp, there is a similar pair for calculateWidthOfLine. Why > isn't there a conversion function to and from layout units to eliminate > these redundancies? It seems that this would be much less error prone > than the current approach. > > Yours, > Matt >
