Re: Patch: Fix for Bug 1164, 2nd try

[Hubert Figuiere]

According to Vlad Harchev <[EMAIL PROTECTED]>:
> > > > 
> > > > The problem is with the 'else' clause of the 'if'. When the
> > > > m_mbtowc.mbtowc() return 0, the 'else' reset the m_mbtowc.
> > > > Now we lost the internel buffer. Comment it out will bring
> > > > the cjk import to its old shape.
> > > 
> > >  The code in AW 0.7.14 is
> > >                       if (no_convert==0 && ch<=0xff)
> > >                       {
> > >                               wchar_t wc;
> > >                               if (m_mbtowc.mbtowc(wc,(UT_Byte)ch))
> > >                                       return AddChar(wc);
> >                             else
> >                                     m_mbtowc.initialize();
> > >                       } else
> > >                               return AddChar(ch);
> > > 
> > >  I don't see how 'else' can reset buffer (AddChar(ch) doesn't reset it
> > > either). Or did RTF importer change there since 0.7.14?
> > 
> > It has changed. See above.
> > Committer is dom on May 3 (revision 1.58). Dom, can you explain what it is for ?
> 
>  Thank you for research. That added chunk:
>                                else
>                                        m_mbtowc.initialize();
>  should be definitely removed. 


Dom, can you comment on this ? I'd like to get this problem fixed, but
I'd like to know why you did this.

Thanks

Hub