sam th --- [EMAIL PROTECTED] --- http://www.abisource.com/~sam/
OpenPGP Key: CABD33FC --- http://samth.dyndns.org/key
DeCSS: http://samth.dyndns.org/decss
>From [EMAIL PROTECTED] Wed May 30 21:10:23 2001
Return-Path: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
Received: from hotmail.com (f28.law3.hotmail.com [209.185.241.28])
by parsons.abisource.com (Postfix) with ESMTP id 82B1111C001
for <[EMAIL PROTECTED]>; Wed, 30 May 2001 21:10:17 -0500 (CDT)
Received: from mail pickup service by hotmail.com with Microsoft SMTPSVC;
Tue, 29 May 2001 05:45:46 -0700
Received: from 63.86.139.88 by lw3fd.law3.hotmail.msn.com with HTTP; Tue, 29 May
2001 12:45:46 GMT
X-Originating-IP: [63.86.139.88]
Reply-To: [EMAIL PROTECTED]
From: "Dom Lachowicz" <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED], [EMAIL PROTECTED]
Subject: Re: Commit: Styles Work. Big bug in hashtable.
Date: Tue, 29 May 2001 08:45:46 -0400
Mime-Version: 1.0
Content-Type: text/plain; format=flowed
Message-ID: <[EMAIL PROTECTED]>
X-OriginalArrivalTime: 29 May 2001 12:45:46.0979 (UTC) FILETIME=[48495B30:01C0E83D]
There probably isn't a bug in the hashtable like the one you describe.
You're probably passing in a string that points to some transient spot in
memory while importing the file. The quick and dirty solution is to
UT_strdup the strings. The better solution is the following:
Recode the HT to only accept AbiObjects as Keys (and possibly Values too).
Maintain proper reference counting, sinking and ref'ing and unref'ing the
objects as necessary. Now that UT_String has AbiObject as its anscestor, you
can use it to store your strings, for example.
I'd do all of this but I'll be away from AbiWord coding until at least June
3 due to all sorts of work and outside requirements.
Martin, you have the helm :-)
Dom
>From: Martin Sevior <[EMAIL PROTECTED]>
>To: [EMAIL PROTECTED]
>CC: Dom Lachowicz <[EMAIL PROTECTED]>
>Subject: Commit: Styles Work. Big bug in hashtable.
>Date: Tue, 29 May 2001 18:19:06 +1000 (EST)
>
>
>OK deleting styles now work except for bugs in the new hashtable. We can
>stack style properties using the basedon parameter.
>Deleting both character and Paragraph styles works. Text in the document
>gets updated corretly upon exit from the styles dialog.
>
>Also fixed the bidi build.
>
>Also made a minor fix so that rtf importers that don't understand lists
>get our lists correct.
>
>Very interestingly, Ted which does such a fine job of importing rtf tables
>has zero support for autonumbering of Lists!
>
>The bad new is that there is a major bug in the new hastable exposed upon
>import of files with styles. The style names defined in the document get
>hosed upon import.
>
>See pt_PT_Style.cpp. I've put in some debugging code so that hashtable
>experts can see what's going wrong.
>
>Cheers
>
>Martin
>
>PS. Still don't know if abisousrce.com will eat this email...
>
>
>CVS: ----------------------------------------------------------------------
>CVS: Enter Log. Lines beginning with `CVS:' are removed automatically
>CVS:
>CVS: Committing in .
>CVS:
>CVS: Modified Files:
>CVS: src/af/xap/xp/xap_App.cpp src/text/fmt/xp/fl_DocListener.cpp
>CVS: src/text/fmt/xp/fv_View.cpp src/text/ptbl/xp/pd_Document.cpp
>CVS: src/text/ptbl/xp/pd_Document.h
>CVS: src/text/ptbl/xp/pt_PT_Styles.cpp
>CVS: src/wp/ap/unix/ap_UnixDialog_Styles.cpp
>CVS: src/wp/ap/xp/ap_Dialog_Styles.cpp
>CVS: src/wp/impexp/xp/ie_exp_RTF_listenerWriteDoc.cpp
>CVS: ----------------------------------------------------------------------
>Fix deleting of styles. Hastbale hoses Style names upon document import.
>
>
_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com
PGP signature
