Mike Nordell wrote:
> 
> Correctness:
> Something has seriously degraded lately, and that is type correctness.
> 
> Please, be aware that once you perform an arithmetic operation on a datatype
> (such as operator+) you are indeed often creating a new dataype, e.g. short
> + int != short, why you can't really compare the result to a short.

<snip> What timing!  I was just compiling the same list to post! (:

> Compilation speed:
> Please, keep track of what you include into header files. Currently AbiWord
> is such an entagled mess of includes that I can't build it _below_ five
> minutes, while a year ago (I don't care of the "progress", it's not a part
> of this) I couldn't get _above_ 90-120 seconds!

That's nothing.  On Windows it takes about 15-20 mintues!  Most of
the time I can just build the parts I know are affected but when a
header is changed... I have to go for a walk to the shops.

> To give an example: why the ... should the event manager have _anything_
> to do with iconv?!
> Well, xap_EncodingManager is coded in a way that it includes "iconv.h", and
> thereby _forcing anyone_ including that header file to _including_ the iconv
> include dir into its "-I" compiler flags.
> 
> If possible (and accepted by the lot) I'd _really_ like if we started to use
> "../../foo/bar.h" since this hierarchy is more or less cast in stone anyway.
> It's not like anyone ever even _could_ take a directory like
> "abi/src/af/xap/unix" and move it to another place and expect the makefiles
> to still function. (the current style is hurting compilation performance,
> that's why I mention it)
> 
> Yes, I'm just complaining without fixing any of this. I didn't write this to
> get points, I wrote it to open eyes. If that makes me look bad, so be it; so
> long as it enhances the quality of AbiWord.

I'm in favour of fixing all of these things and willing to assist.

Andrew.

-- 
http://linguaphile.sourceforge.net

_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com


Reply via email to