On Wed, 19 Dec 2001, Hubert Figuiere wrote:

> OK.
> 
> This time I'm gonna rant.
> 
> in abi/src/af/xap/unix/gnome/xap_UnixGnomeFrame.cpp, someone added 
> 
> #include "libgnomevfs/gnome-vfs.h"
> 
> Without testing for #ifdef (has been removed in fact). I must say NO to that
> practice. I'm really tempted to backout THAT patch.
> 
> 
>http://www.abisource.com/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=abi/src/af/xap/unix/gnome&command=DIFF_FRAMESET&root=/cvsroot&file=xap_UnixGnomeFrame.cpp&rev1=1.26&rev2=1.27
> 

Yes, that was me. You'll notice that that code is is in the gnome branch
of abiword. gnome-vfs is part of the gnome platform so no need for an
#ifdef

Cheers

Martin



Reply via email to