Like I told him outside the list (while nyorp was sick), this does not really do much of anything besides moving time spent from parent accountability to self accountability. I need to know what other compilers do though. Especially win32. MPritchet or Perdition (or some other win32 guru) can you send me the profiling info with and without plam's patch?
I did a simple enough test by (make sure you do it very precisely the exact same way on both builds) 1) Open abiword. Make sure you dont accidentally click anywhere, move the cursor, etc. 2) Press 'a' five times. 3) Press shift-left three times. 4) Press shift-right three times. 5) Press backspace 5 times. 6) Press alt-f. 7) Press x. 8) When prompted to save, tab 3 times (or so) to bring button focus to "no". 9) enter. Sorry to be so nitpicky. On Fri, 2002-04-05 at 18:09, Patrick Lam wrote: > inline some function definitions which were showing up as hot spots > CVS: ---------------------------------------------------------------------- > CVS: Enter Log. Lines beginning with `CVS:' are removed automatically > CVS: > CVS: Committing in . > CVS: > CVS: Modified Files: > CVS: src/af/xap/xp/xap_App.h src/af/xap/xp/xap_Prefs.h > CVS: ---------------------------------------------------------------------- > > I trust that the C++ compiler will now do the right thing; on one of > mg's profile runs, the methods in question were taking 1.5% of the > execution time (which was a large chunk for accessor methods). A smart > C++ compiler would've automatically inlined them, but oh well. > > pat
