--- Begin Message ---
On Sat, 2002-11-30 at 03:40, Hubert Figuiere wrote:
> On Saturday, Nov 30, 2002, at 07:53 Europe/Paris, William Lachance 
> wrote:
> 
> > Hub: m_pFrame in xap_FrameImpl needs to be accessed by its child
> > classes, so it can't just be set to private without giving the children
> > some way of accessing it. I think setting it to protected is a good way
> > of doing so.
> >
> I did put a public getFrame() for that purpose. One of the reason is 
> that I have to access it from Obj-C classes that I can't make friend of 
> it. I moved m_pFrame to private because I don't want anyone else access 
> it to overwrite it. That is encapsulation.

Ok, I understand the logic behind this. Thanks for volunteering to fix
this (I'm going to be out for the weekend). For any other newcomers to
AbiWord: you might find this post by Joaquin, ages ago, interesting:

http://www.abisource.com/mailinglists/abiword-dev/01/April/0468.html

Cleaning up the frame code to eliminate all protected variables in the
frame code is a big job. I will try to work on this incrementally, but
my time is limited. So if anyone's looking for an open job..

Cheers,
-- 
William Lachance <[EMAIL PROTECTED]>
--- End Message ---

Reply via email to