Sorry for the mess up. A new patch is attached for Applix. I am in the process of
redoing the xhtml patch now.
Just so I understand the policy, extranous white space at the end of files should
not be deleted? Also, what about reformating character lists? In particular, the
wordperfect/ie_imp_WordPerfect.cpp file has an array: char magic[192] that
seems like it should be formated into a readable list. I would like to submit
my fixups to the wordperfect directory as soon as I can get libwpd to compile
for testing. If I should leave that array looking the way it is I would like to know
before I submit the patch.
At present it reads:
...(char)0x00, (char(0x55),...
and in many cases the line wraps multiple times due to line liengths in excess of
200 characters.
I would like to arrange things so that it becomes:
...
static_cast<char>(0x00).
static_cast<char>(0x55),
...Especially when you change (char) to static_cast<char> things would get even messier in the origional format.
I am willing to keep the old format, if preferred, but it seems almost unreadable
presently. Also, there are extra ^M characters, and I can not figure out why they
exist. They are not individual entries in the table, but at the end of certain lines.
As an example:
...(char)0x4E, ^M (char)0x25, (char)0x00,...
I believe they should be elimintated, but I wanted to make sure.
-Larin
Dom Lachowicz wrote:
Caveats:
Applix patch is functionally incorrect.
- sBuf += (char)*pData++; + sBuf += reinterpret_cast<char*>(const_cast<UT_UCSChar*>(pData++));
XHTML: patch contained massive removals. I think it needs to re-sync with FJF's most recent work.
Other patches removed or changed whitespace. Not applied.
Docbook, HTML and SDW patches applied.
Dom
CVS: ---------------------------------------------------------------------- CVS: Enter Log. Lines beginning with `CVS:' are removed automatically CVS: CVS: Committing in . CVS: CVS: Modified Files: CVS: wp/impexp/docbook/xp/ie_imp_DocBook.cpp CVS: wp/impexp/html/xp/HTML_StyleString.cpp CVS: wp/impexp/html/xp/HTML_TextState.h CVS: wp/impexp/html/xp/HTML_TokenStack.h CVS: wp/impexp/html/xp/HTML_tags.h CVS: wp/impexp/html/xp/ie_imp_HTML.cpp CVS: wp/impexp/sdw/xp/ie_imp_StarOffice.cpp CVS: wp/impexp/sdw/xp/ie_imp_StarOffice.h CVS: wp/impexp/sdw/xp/sdw_cryptor.cpp CVS: ----------------------------------------------------------------------
__________________________________________________
Do you Yahoo!?
Yahoo! Tax Center - forms, calculators, tips, more
http://taxes.yahoo.com/
applix.diff.gz
Description: GNU Zip compressed data
