On Sun, Apr 15, 2012 at 10:33:40AM +0200, Fabio Zanini wrote: > recently Thorsten Wißmann and I wrote some code to include basic support > for: > - mouse (Thorsten) > - colors (Thorsten) > - mutt groups (mine)
Wow, seems great ! Opening the dance with a very quick review of the mouse and color features (which appear to work flawlessly). * In abookrc.5 there's "use_color" instead of "use_colors" * In options.c you use UL FALSE rather than simply FALSE (while I don't think we need to explicitly cast 0 or 1 to (unsigned long) here) * About colors options naming and after reading naively the new manpage section, I think that something like: color_list_even_* / color_list_odd_* may be more explicit semantics than: color_list_* / color_list_alternate_* * mouse support is nice but making it optional would be even better, I myself often double-click a phone number from abook in order to paste it somewhere else (eg gnokii) what becomes much harder with the color patch, thus an option for the mouse support may makes sense (like most virtual-terminal-based applications do when it comes to mouse) About the "group" patch it may need some more time / more people to be tested / reviewed. About merging: * @Michael, it appears that it's time for the vcard patch to be merged too but unless I missed something, strcasestr() is part of strings.h which is already included somewhere else in abook. => Fabio, in 55b7ed5 you also changed strcasestr() on the way so you may have the answer too. * About autoconf update, I'm not familiar with it but indeed at least both debian and gentoo provide 1.11. But whoever the abook committer will be, he will have to split bb38d092 anyway :) thanks a lot ! [ sorry if dup', just experienced a gmail "+" delimiter / mailman issue ] ------------------------------------------------------------------------------ For Developers, A Lot Can Happen In A Second. Boundary is the first to Know...and Tell You. Monitor Your Applications in Ultra-Fine Resolution. Try it FREE! http://p.sf.net/sfu/Boundary-d2dvs2 _______________________________________________ Abook-devel mailing list Abook-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/abook-devel
