On Wed, Oct 19, 2011 at 08:00:11AM +0200, Leon Romanovsky wrote: > On Tue, Oct 18, 2011 at 22:57, Julian Andres Klode <[email protected]> wrote: > > On Tue, Oct 18, 2011 at 09:37:17PM +0200, Leon Romanovsky wrote: > >> ---------- Forwarded message ---------- > >> From: Leon Romanovsky <[email protected]> > >> Date: Tue, Oct 18, 2011 at 21:30 > >> Subject: [PATCH 2/3] staging: nvec: Fix of the speaker for the > >> suspend/resume stages. > >> To: [email protected] > >> Cc: Leon Romanovsky <[email protected]> > >> > >> > >> Mute speakers before entering to the suspend state and unmute at the > >> resume state. > >> > >> Signed-off-by: Leon Romanovsky <[email protected]> > >> --- > >> drivers/staging/nvec/nvec.c | 2 ++ > >> 1 files changed, 2 insertions(+), 0 deletions(-) > > They should be in nvec_event.c, and actually you can call > > the mute/unmute functions that are there. > There are three reasons why I choose to write it in this way > 1) Patches must be as minimal as possible, to help with bisect and review > 2) The direct call didn't passed compilation, because nvec.c doesn't > see the paz00_unmute/paz00_mute <- I didn't want to invest more time > in it, see p.3 > 3) I don't think that paz00 related code must be in nvec codebase.
That's why they should be in nvec_event, which will become nvec_paz00. _______________________________________________ Mailing list: https://launchpad.net/~ac100 Post to : [email protected] Unsubscribe : https://launchpad.net/~ac100 More help : https://help.launchpad.net/ListHelp
