Hi Leon, On Sunday 22 January 2012 12:25:05 Leon Romanovsky wrote: > On Sun, Jan 22, 2012 at 12:01, Marc Dietrich <[email protected]> wrote: > > This checks if the gpio is valid and frees it during unload of the > > codec module. > > > > Signed-off-by: Marc Dietrich <[email protected]> > > --- > > Hi Andrey, Leon, > > > > attached patch fixes an issure seen by Paul Ferster on IRC (oops after > > module > > unload/reload and hp jack pluged in). > > > > sound/soc/tegra/tegra_alc5632.c | 40 > > > > ++++++++++++++++++++------------------ > > > > (...) > > Hi Mark, > Please, can you specify the branch you based your patch? The 3.0 doesn't > have such code.
it is based on my chromeos-ac100-3.0 tree. Both chromeos-ac100-3.0 and chromeos-ac100-3.0-exp contain this patch and also the patch from Andrey he sent yesterday. > It is too different from upstream and my 3.0 branch. > http://git.kernel.org/?p=linux/kernel/git/broonie/sound.git;a=blob;f=sound/s > oc/tegra/tegra_alc5632.c;h=4a0e805c4edd1b770cf84c85369be81d94375d2f;hb=refs/ > heads/for-next > http://gitorious.org/~leonro/ac100/leonro-marvin24s-kernel/blobs/a70eba97e8 > 082bab91dc860c11836a023a20b8e2/sound/soc/tegra/tegra_alc5632.c It seems you removed hp jack support from your version, maybe because you use this branch for upstreaming. I told Andrey on IRC already that it would be nice to create two public branches for sound. One is based on my "stable" chromos-ac100-3.0 tree and will receive fixes for users to enjoy (like the two latest patches) and one for upstream (maybe based on asoc or linux-next). The latter one does not need to be public, but it makes reviewing easier if you are interested. What do you think? Marc _______________________________________________ Mailing list: https://launchpad.net/~ac100 Post to : [email protected] Unsubscribe : https://launchpad.net/~ac100 More help : https://help.launchpad.net/ListHelp
