Hi, Pete. Looks ok except I think it should return -1 when there's no caret. That's consistent what we do for caretOffset. Thanks. Alex.
On Thu, Feb 9, 2012 at 7:51 AM, Pete Brunet <[email protected]> wrote: > I agree that it's OK to keep the offset parameter, primarily so that out of > process AT won't suffer the penalty of process switches resulting from calls > to QI and IAText::caretOffset. The proposal is at > https://wiki.mozilla.org/Accessibility/IA2_1.3#Caret_offset_and_accessible_containing_the_caret > One additional note is needed: If there is no object containing a caret the > return value would be S_FALSE and the out parameters would be NULL for the > pointer to the IUnknown and 0 for the long. > > Are there any additional issues? > > Pete > > > On 9/7/11 10:02 AM, Alexander Surkov wrote: > > Ok, I buy it. That suggestion was a syntax sugar, it could be useful > for those who is out of process and deprecate caretOffset (at least I > don't see a case what caretOffset can be used for having > accessibleWithCaret). > > Alex. > > > On Wed, Sep 7, 2011 at 10:53 PM, Malte Timmermann > <[email protected]> wrote: > > Magic value sounds strange to me, especially that it would make the OUT > param an INOUT param. > > IA2 is intended to be in process, so I don't think the extra call is a > problem. The AT will make many other calls anyway, like getting text > attributes, object pos/size and other stuff. > > Malte. > > On 07.09.2011 05:18, Alexander Surkov wrote: > > Hi, Pete. The reason is to save an extra call. From my understanding > AT wants to know the caret offset within deepest accessible having a > caret. This doesn't add complexity to server implementation (as you > said all it's needed is to query text interface and call caretOffset). > We could introduce magic value for caret offset argument to specify > that the server shouldn't calculate it. > > Thank you. > Alex. > > > On Sat, Sep 3, 2011 at 5:39 AM, Pete Brunet<[email protected]> wrote: > > Alex, Why does accessibleWithCaret have an [out] caretOffset? The user can > QI to IAText and use IAText::offset. I propose not adding that redundancy > (and thus extra code for the app developers). -Pete > -- > Pete Brunet > > a11ysoft - Accessibility Architecture and Development > (512) 467-4706 (work), (512) 689-4155 (cell) > Skype: pete.brunet > IM: ptbrunet (AOL, Google), [email protected] (MSN) > http://www.a11ysoft.com/about/ > Ionosphere: WS4G > > _______________________________________________ > Accessibility-ia2 mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/accessibility-ia2 > > > _______________________________________________ > Accessibility-ia2 mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/accessibility-ia2 > > _______________________________________________ > Accessibility-ia2 mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/accessibility-ia2 > > _______________________________________________ > Accessibility-ia2 mailing list > [email protected] > https://lists.linux-foundation.org/mailman/listinfo/accessibility-ia2 > > > -- > Pete Brunet > > a11ysoft - Accessibility Architecture and Development > (512) 467-4706 (work), (512) 689-4155 (cell) > Skype: pete.brunet > IM: ptbrunet (AOL, Google), [email protected] (MSN) > http://www.a11ysoft.com/about/ > Ionosphere: WS4G > > _______________________________________________ > Accessibility-ia2 mailing list > [email protected] > https://lists.linuxfoundation.org/mailman/listinfo/accessibility-ia2 > _______________________________________________ Accessibility-ia2 mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/accessibility-ia2
