On Thu, Oct 13, 2011 at 4:36 PM, Adam Fuchs <[email protected]> wrote: > +1 for consistent formatting. > +1 for tabs. > -1 for spaces. > > Tabs are nice because everyone can choose their own look and feel (i.e. I > don't have to look at 2-space indenting!). >
I would like to get to make a decision and reformat the existing code ASAP. I was undecided this morning, I did not think there was a clear advantage to one or the other. We were discussing the pros and cons. It seems the main pro w/ spaces, is consistency. The code looks the same everywhere (in less, vim, eclipse, code coverage tool, notepad, etc). With tabs, each one of these tools would need to be configured by the user to achieve consistency. The pro w/ tabs is that each user can make the code look how they like. I like the idea of a consistent look in all tools and being able to modify the tab stop is not important to me, I will get used to whatever we decide to go with. +1 for spaces (using hadoop formatting style) -1 for tabs Keith
