[
https://issues.apache.org/jira/browse/ACCUMULO-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160128#comment-13160128
]
Keith Turner commented on ACCUMULO-14:
--------------------------------------
Here are my thoughts on updating vars to final simultaneously w/ this feature.
* Makes the patch harder to review for this feature.
* Makes the patch harder to merge to other branches. (For example if I want to
merge feature X and not Y to an older branch, but the patch contains feature X
and Y commingled.)
* Final was only added to the classes changed for this feature. If you really
think it is a worthwhile improvement, it may be worth making a large change and
tacking that in one ticket.
* When looking at code for forensics reasons trying to fix a bug, I have found
in some cases that svn revisions targeted to a specific feature or bug fix are
helpful when trying to understand why a change was made and what code that
change affected.
I am actually making a more general argument for keeping patches concise to the
primary feature being addressed by the patch.
> Transition from full Accumulo mocking
> -------------------------------------
>
> Key: ACCUMULO-14
> URL: https://issues.apache.org/jira/browse/ACCUMULO-14
> Project: Accumulo
> Issue Type: Improvement
> Components: client
> Reporter: Jesse Yates
> Fix For: 1.5.0
>
> Attachments: java_ACCUMULO-14-start-formatted.patch,
> java_ACCUMULO-14-start.patch
>
>
> Original discussion present
> here:http://mail-archives.apache.org/mod_mbox/incubator-accumulo-dev/201110.mbox/%3CCAGUtCHrN3p-7C8Uz7eT0Ze4L0ORzDj1f-x-JWdyrLc=Kx=o...@mail.gmail.com%3E
> Jesse Yates: "Maintaining a real instance and a mock instance ends up
> creating a lot of extra work for dev's by ensuring that there impls are kept
> synchronized....[using a real] instance of Accumulo running on the local file
> system. This would mean less work in the long run to maintain a separate
> instance and better testing for users and new features."
> Keith Turner: "its very fast to create a mock instance which means that unit
> test run very quickly...[and] its all in process which is useful for
> debugging...making mock leverage more of the actual accumulo code, but
> possibly keep it in process for speed and debugging."
> This ticket is to track the discussion and development of a less mocked test
> instance of accumulo, that relies more heavily on the actual implementation,
> rather than parallel mocking features.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
