I'd like to make a change to the interface
net.sf.acegisecurity.providers.jaas.JaasAuthenticationCallbackHandler
The reason I'm posting here is that this is a contract change to the
interface, due to too much drinking on my part or something...
The interface is currently
public interface JaasAuthenticationCallbackHandler {
void setAuthentication(Authentication auth);
void handle(Callback callback)
throws IOException, UnsupportedCallbackException;
}
This, as pointed out by a user on the boards, is an issue in the
JaasAuthenticationProvider as it makes the calls...
callback.setAuthentication(authentiation);
callback.handle(callback);
in succession.
This is a concurrency issue. The quick fix is to wrap those two calls
in a synchronized block. The real fix is to drop the setAuthentication
method and modify the handle method to be handle(Callback,
Authentication).
As it is a contract change I wanted to check with the team first.
What do you guys think?
-Ray
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Home: http://acegisecurity.sourceforge.net
Acegisecurity-developer mailing list
Acegisecurity-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer
