Shouldn't the AbstractFilterInvocationDefinitionSource
getAttributes(...) be using getPathInfo() instead?

diff -r1.2 AbstractFilterInvocationDefinitionSource.java
45c45
<         String url = ((FilterInvocation) object).getRequestUrl();
---
>         String url = ((FilterInvocation) object).getHttpRequest().getPathInfo(
);

I've made the change here and everything tests fine, I didn't want to
commit it without a second opinion though.

I'm pretty sure that's how the older .7 stuff worked.
-Ray



On Sun, 20 Mar 2005 13:45:23 +0000, Luke Taylor <[EMAIL PROTECTED]> wrote:
> I suppose in most cases the query string won't be required for a match,
> so perhaps FilterInvocation should exclude the query string. It's also a
> bit confusing because getRequestURL() and getRequestURI() on HttpRequest
> don't include the query string.
> 
> For matching, can't you just add "\??.*" to the expressions which might
> have a query?
> 
> Luke.
> 
> --
>   Luke Taylor.                      Monkey Machine Ltd.
>   PGP Key ID: 0x57E9523C            http://www.monkeymachine.ltd.uk
> 
> -------------------------------------------------------
> SF email is sponsored by - The IT Product Guide
> Read honest & candid reviews on hundreds of IT Products from real users.
> Discover which products truly live up to the hype. Start reading now.
> http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
> _______________________________________________
> Home: http://acegisecurity.sourceforge.net
> Acegisecurity-developer mailing list
> Acegisecurity-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer
>


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Home: http://acegisecurity.sourceforge.net
Acegisecurity-developer mailing list
Acegisecurity-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acegisecurity-developer

Reply via email to