http://bugzilla.kernel.org/show_bug.cgi?id=5749
[EMAIL PROTECTED] changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |NEW
Resolution|CODE_FIX |
------- Additional Comments From [EMAIL PROTECTED] 2006-07-26 19:26 -------
RE: sysfs API
/sys/hotkey -- unclear if everything should live here,
but okay for a prototype, need to make the values generic
so a user-program can understand on every system:
This API must be available with CONFIG_ACPI=n also.
/sys/class/graphics/ (first guess)
available_displays: lcd, crt, tv other...
current_display = set to one of above
brightness_max = # maximum on this box
brightness_min = # minimum on this box
brighness = # current brightness within range above
zoom_max = # maximum zoom level
zoom_min = # ...
zoom= # current zoom level
/sys/class/device/sound/audio (first guess)
volume_min = #
volume_max = #
volume = #
----------
Re: /proc
Every use of /proc in this driver should be #ifdef DEBUG
make DEBUG a sub-CONFIG option of CONFIG_ACPI_HOTKEY
even better, have hotkey_debug.c link in, and not even
be in the production source.
hotkeylib.c: needs to make private functions static to avoid
name space pollution. Needs new name, or to be split up
into multiple places.
--------
Documentation/acpi-hotkey.c
delete this, nobody can understand it, and it is DEBUG only.
or at least make it clear it is for development only
and that in production use /proc is unused.
-----------
replace acpi_bus_generate_event() with input_report_key() in hotkey.c
new use of /proc/acpi/event should not be added with this driver.
linux/input.h has the scancodes to use.
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
acpi-bugzilla mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
