http://bugzilla.kernel.org/show_bug.cgi?id=7122





------- Additional Comments From [EMAIL PROTECTED]  2006-09-11 14:20 -------
The thermal zones and fans initialization code seems to be incorrect, because it
may cause the same powered resource to be acquired twice in a row for the same
purpose.

For example on this box the thermal zones initialization is carried out before
the initialization of fans.  However, during the thermal zones initialization
some fans may be turned on due to the thermal requirements.  On this box this
generally leads to some power resources being turned on.  For example, if the
thermal code decides it should turn fan C352 on, it will attempt to do so and
power resource C34E will be turned on.  Next, the initialization of fans will
attempt to unconditionally turn fan C352 on again and that will lead to
resource->references in C34E being increased for the second time for the same
purpose (ie. keeping fan C352 on).  From the logical point of view it's as
though fan C352 had two references on the power resource C34E, which is
incorrect, because it suggests there are two devices that need this power
resource to stay on, but in fact there's only one.

My understanding is that we may want to make device->power_state reflect the
actual state of the device (eg. fan), but IMHO for this purpose we should use
a simplified version of acpi_power_transision() that calls a function which
doesn't change resource->references instead of acpi_power_on(), if
device->flags.force_power_state is set in acpi_bus_set_power().


------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
acpi-bugzilla mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to