http://bugzilla.kernel.org/show_bug.cgi?id=14279





--- Comment #8 from Jan Beulich <jbeul...@novell.com>  2009-10-06 07:52:20 ---
>>> "Rafael J. Wysocki" <r...@sisk.pl> 06.10.09 00:20 >>>
>On Monday 05 October 2009, bugzilla-dae...@bugzilla.kernel.org wrote:
>> http://bugzilla.kernel.org/show_bug.cgi?id=14279 
>> 
>> --- Comment #4 from Christian Casteyde <casteyde.christ...@free.fr>  
>> 2009-10-05 21:47:41 ---
>> 10 compile and 15 reboots later ;-)
>> 
>> The faulty commit is the following:
>> 
>> r...@athor:/home/christian# cd /usr/src/linux-git
>> r...@athor:/usr/src/linux-git# git bisect bad
>> 5f68563996e812f9ca35b3939ad2a42e5d254d66 is first bad commit
>> commit 5f68563996e812f9ca35b3939ad2a42e5d254d66
>> Author: Jan Beulich <jbeul...@novell.com>
>> Date:   Fri Sep 4 09:16:22 2009 +0100
>> 
>>     x86: cpuinit-annotate SMP boot trampolines properly
>> 
>>     Add missing annotations, and make use of include/linux/init.h's
>>     macros.
>> 
>>     Signed-off-by: Jan Beulich <jbeul...@novell.com>
>>     LKML-Reference: <4aa0e8f60200007800013...@vpn.id2.novell.com>
>>     Signed-off-by: Ingo Molnar <mi...@elte.hu>
>> 
>> :040000 040000 cc41898cf8c087ce4d5b1a9d7f98cef17b4766a1
>> 311e4ed7f38529ce629d5ef130d3bf52e15f783c M      arch
>> r...@athor:/usr/src/linux-git#
>
>Thanks a lot for bisecting!

>...
>Jan, Ingo, can you have a look at this, please?
>
>The trampoline is also used for resuming from suspend to RAM on x86_64.

Correct, but SUSPEND+SMP select HOTPLUG_CPU, and that results in
the trampoline not being discarded. So this must be a !SMP config, and
I must have missed a section mismatch warning resulting from
acpi_save_state_mem() referencing setup_trampoline() (it's too bad that
these warning continue to be suppressed by default).

In order to not introduce even uglier CONFIG_X86_64 conditionals, I
think the only solution is to revert the whole patch, even though I
dislike retaining the trampoline on 32-bits just because it's needed on
64-bits.

Jan

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to