https://bugzilla.kernel.org/show_bug.cgi?id=15174
--- Comment #14 from D. Hugh Redelmeier <h...@mimosa.com> 2010-03-22 15:10:46 --- Zhang Rui: You didn't say what you changed in this patch. It looks to me as if you changed the code that made sure that (1) good entries retained their original subscript, and (2) filled the hole left by a bad entry with the next legitimate entry (if any). Why did you delete that part of the code? That code is necessary, in theory, if you read how _PSS entries are used. I explained this in #5. That feature happens not to be needed in my computer, nor in the laptop you describe in #12. This is because all the bad entries are at the end. If you think that that is the only case that needs to be handled, the correct version of the code would just exit the loop on the first bad entry it finds (and a separate j variable would not be needed). If there happens to be a bad entry before good entries, your patch will cause the good entries to no longer be at the expected subscript so the result will be wrong. For example: 1: good1 2: bad 3: good3 becomes (with your version of the patch) 1: good1 2: good3 (3 no longer a valid subscript) Since the _PPC method could return a value "3", we've turned a working system into a non-working system. The previous patch would have created: 1: good1 2: good3 3: good3 which would leave _PPC still functioning. -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ acpi-bugzilla mailing list acpi-bugzilla@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
