https://bugzilla.kernel.org/show_bug.cgi?id=42870





--- Comment #3 from Andreas Müller <[email protected]>  2012-07-14 
16:35:07 ---
Created an attachment (id=75371)
 --> (https://bugzilla.kernel.org/attachment.cgi?id=75371)
setup state-info for new surfacing states

The problem seems to be with 46bcfad7a819bd17ac4e831b04405152d59784ab, a rather
large modification.

acpi_processor_cst_has_changed() calls acpi_processor_setup_cpuidle_states()
before setting up "pr->power.states[]", which would happen in
acpi_processor_get_power_info(). So, this array only contains the old valid
states. Eventhough get_power_info() will be called right after and updates the
processors data, the driver's (cpuidle_driver) information about the states
will not be updated.

Furthermore, the cpuidle_driver sets the states[i].power_usage only when it is
registered. There is no update, so power_usage of the surfaced state would be
zero and is therefore not considered.

In this patch, acpi_processor_get_power_info() will be called for processor 0
right before the cpuidle-driver's state info will be updated.
Furthermore, the states[].power_usage variable will be set as cpuidle_driver
would do, it might be more consistent to let it do it by itself but for now it
doesn't hurt (me :).

There still seems to be a problem with accounting time in C0 after
cst_has_changed. But this seems to be that way for some time, unrelated to this
patch.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
acpi-bugzilla mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to