https://bugzilla.kernel.org/show_bug.cgi?id=42696
--- Comment #22 from Peter <lekenst...@gmail.com> 2013-03-15 12:42:58 ---
Rafael, it seems that you have pushed a change that fixes this issue (reported
by a user of 3.9-rc2[1]), essentially doing the same as comment 7:
commit 33f767d767e9a684e9cd60704d4c049a2014c8d5
Author: Rafael J. Wysocki <rafael.j.wyso...@intel.com>
Date: Thu Jan 10 13:13:49 2013 +0100
ACPI: Rework acpi_get_child() to be more efficient
Observe that acpi_get_child() doesn't need to use the helper
struct acpi_find_child structure and change it to work without it.
Also, using acpi_get_object_info() to get the output of _ADR for the
given device is overkill, because that function does much more than
just evaluating _ADR (let alone the additional memory allocation
done by it).
Moreover, acpi_get_child() doesn't need to loop any more once it has
found a matching handle, so make it stop in that case. To prevent
the results from changing, make it use do_acpi_find_child() as
a post-order callback.
Signed-off-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com>
I cite a mail from Len:
On Friday 16 November 2012 11:25:47 Len Brown wrote:
> Peter,
>
> It is great that you debugged this issue
> and proved where the problem is.
>
> However, this patch can't possibly be the right way to go --
> as it is just as broken as the code it replaces.
> Were I to bet, I'd say that it will break as many machines
> as it fixes. And when it does, where are we?
>
> Clearly we need to be using a more clever search algorithm.
>
> thanks,
> Len Brown, Intel Open Source Technology Center
So, apparently the bug is fixed in a correct way now? If another user can
confirm it here, I'll mark it as resolved.
[1]:
https://github.com/Bumblebee-Project/bbswitch/issues/2#issuecomment-14939587
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
