https://bugzilla.kernel.org/show_bug.cgi?id=97841
--- Comment #2 from Bastien Nocera <[email protected]> --- (In reply to Aaron Lu from comment #1) > (In reply to Bastien Nocera from comment #0) > > I have access to a convertible Toshiba machine where the 2nd battery > > is in detachable keyboard. This is the decompiled DSDT: > > https://hadess.fedorapeople.org/toshiba.dsl > > > > There's no BAT0, BAT1 is in the screen, and BAT2 is in the keyboard. > > > > BAT2 can be ejected (it has an _EJD method), but the dock code doesn't > > see it as having a battery: > > $ pwd > > /sys/devices/platform/dock.0 > > $ cat flags > > 16 > > $ cat type > > dock_station > > The kernel creates a dock station when it sees the following three types of > ACPI device node: > 1 ACPI device node that has _DCK control method, as the DOCK device node in > your dsdt table and is represented as dock.0 above; > 2 Battery, when it has a _EJ0 control method; > 3 ATA, when it has a _EJ0 control method. > > The 4-8 bits of the flag is used to represent such information, but not that > if it contains some devices in it. Right. But why don't the flags get set to mention "DOCK_IS_BAT" when it has the _EJD method? The device: Device (BAT2) { Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) // _HID: Hardware ID Name (_UID, 0x02) // _UID: Unique ID Name (_PCL, Package (0x01) // _PCL: Power Consumer List matches the requirement for acpi_device_is_battery() returning TRUE: bool acpi_device_is_battery(struct acpi_device *adev) { struct acpi_hardware_id *hwid; list_for_each_entry(hwid, &adev->pnp.ids, list) if (!strcmp("PNP0C0A", hwid->id)) return true; -- You are receiving this mail because: You are watching the assignee of the bug. ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ acpi-bugzilla mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla
