https://bugzilla.kernel.org/show_bug.cgi?id=215882

--- Comment #10 from Lance G. (gero3...@gmail.com) ---
(In reply to Hans de Goede from comment #8)
> (In reply to Lance G. from comment #6)
> > I tried charging anyways without using the workarounds and with
> 'axp288_adc'
> > blacklisted. The red battery light came on as if it were charging.
> 
> Right, so I guess that some part of the:
> 
> modprobe i2c-dev
> i2cset -y -f 6 0x34 0x82 0xf0
> i2cset -y -f 6 0x34 0x84 0xf0
> 
> Workaround which you have been using somehow sticks around even after a
> power-cycle.
> 
> These tablets often have a mode where they show an animation when charging
> while turned off.
> 
> Can you try turning the tablet off without the charger connected and then
> plug in the charger and see if you get such an animation? If you do then
> after that boot 
> with 'axp288_adc' still blacklisted and then dump the 2 registers again.
> 
> If that does not make any change, then I wonder what happens if you do load
> the axp288_adc driver and then try to charge the tablet ? It sounds to me
> like that should just work. IOW it seems that your workaround maybe is no
> longer needed ?

I have 'S5 Charging Driver' and 'S5 LPM Settings' switched on in the BIOS. I
noticed without those enabled the tablet would still light the red light as if
charging but no animation would play. With those enabled I get a nice battery
status animation when the tablet is fully powered off from the operating system
but is plugged in and charging.

I let my tablet power off and go through the animation. As soon as the
animation came up I unplugged and started boot again.  Those i2c registers
still show the same values and 'axp288_adc' was blacklisted at the time.  


> Another interesting data point would be if you can unplug the battery, or
> keep the tablet on till it powers off due to the battery being dead (check
> it does not power-up again without charging) and then after that boot with
> 'axp288_adc' still blacklisted and then dump the 2 registers again, so that
> we know we really have the firmware set values and not values previously set
> by the workaround sticking over a reboot.

I can try this sometime later.

> Talking about the workaround. I assume you have disabled any systemd units
> you have
> written to do this automatically?

I know I don't have anything enabled regarding workarounds. I have been needing
to manually 'sudo modprobe i2c-dev' just to be able to make use of the 'i2cget'
and 'i2cset' commands

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to