https://bugzilla.kernel.org/show_bug.cgi?id=217754

--- Comment #34 from Mario Limonciello (AMD) (mario.limoncie...@amd.com) ---
OK so your firmware does advertise it as "ExclusiveAndWake":

>                    GpioInt (Level, ActiveLow, ExclusiveAndWake, PullNone,
>                    0x0000,
>                        "\\_SB.GPIO", 0x00, ResourceConsumer, ,
>                        )
>                        {   // Pin list
>                            0x0009
>                        }

AFAICT Windows and Linux *should* both be treating this as a wake source with
this firmware declaration.
https://learn.microsoft.com/en-us/windows-hardware/drivers/bringup/device-power-management#wake-capable-interrupts-_crs

6.1.39 configures it as *not* an S0i3 wake source:
> 2023-08-13 02:33:36,578 DEBUG:        #9      int + (😛)| active-↓| level-⚡|
> S0i3  ∅| S3  ∅| S4/S5  ∅| pull-↑ ∅ (  )| pull-↓ ∅| input  ↑| debounce   ∅ (🕑
> 0us)|  0x51b00

6.1.40 configures it as an S0i3 wake source:
2023-08-13 02:43:06,823 DEBUG:  gpio      int|active|trigger|S0i3| S3|S4/S5|
Z|wake|pull|  orient|       debounce|reg
2023-08-13 02:43:06,823 DEBUG:  #9         😛|     ↓|  level|  ⏰|   |     |  |  
 |    |input  ↑|               |0x53b00

Can you please try the patch I suggested in comment #31 and share your
experience and an updated s2idle report?

Also, can you please try the latest 6.4.y or 6.5-rc6?  I have a suspicion that
we might be missing some other patches in 6.1.y and it's contributing to this
issue.

Specifically this series:
https://lore.kernel.org/all/20220929093200.v6.1.Id4b4bdfe06e2caf2d5a3c9dd4a9b1080c38b539c@changeid/

----
BTW FWIW I double checked this on an AMD reference platform with 6.5-rc5.  The
touchpad is connected to GPIO 8 on this platform and configured as an S0i3 wake
source (same as yours).

>                GpioInt (Level, ActiveLow, ExclusiveAndWake, PullUp, 0x0000,
>                    "\\_SB.GPIO", 0x00, ResourceConsumer, ,
>                    )
>                    {   // Pin list
>                        0x0008
>                    }

gpio      int|active|trigger|S0i3| S3|S4/S5| Z|wake|pull|  orient|      
debounce|reg
#8         😛|     ↓|  level|  ⏰| ⏰|   ⏰|⏰|    |  ↑ |input  ↑|              
|0x815fb00

I did confirm it stays in suspend and waking from the touchpad works on this
kernel.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to