change org.apache.activemq.network.jms.JmsConnector.init() method signiture, so 
broker is not started if the JmsConnectors for it can not be initialized 
properly
-----------------------------------------------------------------------------------------------------------------------------------------------------------------

         Key: AMQ-662
         URL: http://jira.activemq.org/jira//browse/AMQ-662
     Project: ActiveMQ
        Type: Improvement

    Versions: 4.0 M4    
 Environment: all
    Reporter: Fan Li
     Fix For: UNKNOWN


org.apache.activemq.network.jms.JmsConnector.init()
change the method signiture from:
    public boolean init();
to
    public boolean init();

This also require changes to be made in the JmsQueueConnector and 
JmsTopicConnector classes. In case there is an Exception caught during init, 
the Exception is both logged and throw up. For instance, for JmsQueueConnector:
    public boolean init() throws Exception {
        boolean result=super.init();
        if(result){
            try{
                initializeForeignQueueConnection();
                initializeLocalQueueConnection();
                initializeInboundJmsMessageConvertor();
                initializeOutboundJmsMessageConvertor();
                initializeInboundQueueBridges();
                initializeOutboundQueueBridges();
            }catch(Exception e){
                log.error("Failed to initialize the JMSConnector",e);
                throw new Exception("Failed to initialize the 
JMSQueueConnector", e);
            }
        }
        return result;
    } 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.activemq.org/jira//secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to