[ 
https://issues.apache.org/activemq/browse/AMQCPP-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_37948
 ] 

Albert Strasheim commented on AMQCPP-49:
----------------------------------------

Currently Visual Studio builds with warning level 2. The reason for this is 
probably the relatively large amount of type conversion warnings emitted when 
compiling AMQCPP.

I'd be willing to prepare a patch to fix some of these, if you're interested. 
Many places in the API use ints (following the Java example), where the "size" 
type in C++ should probably be std::size_t, not int. Fixing these conversions 
might allow us to avoid a few lurking issues on 64-bit platforms.

> Add -W -Wall compile options
> ----------------------------
>
>                 Key: AMQCPP-49
>                 URL: https://issues.apache.org/activemq/browse/AMQCPP-49
>             Project: ActiveMQ C++ Client
>          Issue Type: Improvement
>         Environment: gcc
>            Reporter: Nathan Mittler
>         Assigned To: Nathan Mittler
>            Priority: Trivial
>             Fix For: 2.0
>
>         Attachments: vs2005-build.diff
>
>
> Add -W -Wall compile options and clean up resulting warnings

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to