On 10/20/06, Hayden, Charles (Charles) <[EMAIL PROTECTED]> wrote:
I don't have any problem doing this, but I hesitate for the following reasons. 1. I know next to nothing about this. I have been using activemq and stomp for all of three days, and have no recent java experience. I was just trying to make the sample program work.
Sweet! Sounds like your quest for execelence / need to scratch an itch is going to make you an awesome ActiveMQ contributor! Allready wanting to fix things after 3 days eh! 2. Although (1) should stop me, I am foolhardy enough to press on. Please press! However, I am not sure whether it is a good idea to change the parameter
name at this time. If I correct the spelling, then existing stomp clients will break (implementations in each language have to be changed). Furthermore, to the extent that stomp is used to communicate
between servers, this change will mean the new servers cannot
interoperate with old ones. I just don't have the perspective to make this kind of decision.
Good point! And here's my take on it: The 4.0.x series of releases are our stable branch where only bug fixes make it in there. The 4.1 release we are adding new feature and may slightly break some things to make it better. Your fix should go in here for sure. But since I consider an incorrect parameter name a bug, I think we should do something about it in the 4.0.x branch. Perhaps try to figure out how we can map the misspelled and the correct property name to the same property. By the way, I believe the ConsumerInfo class is where the typo is.
I will change the wiki to describe the current state of affairs and let those more knowledgeable fix the real problem.
Thanks! -----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Hiram Chirino Sent: Thursday, October 19, 2006 7:42 PM To: [email protected] Subject: Re: durable subscriptons doh! send us a patch and edit the wiki! Lets make it right :) On 10/19/06, Hayden, Charles (Charles) <[EMAIL PROTECTED]> wrote: > > Is there a reason that the header field for durable subscriptions in > Stomp is spelled subcriptionName rather than the more intuitive > subscriptionName? The web page describing how to use this > (www.activemq.org/site/stomp.html) mentions this field three times, > spelled three different ways, none of them the way it is spelled in the > code. > > > -- Regards, Hiram Blog: http://hiramchirino.com
-- Regards, Hiram Blog: http://hiramchirino.com
