here is the file (attached) thanks for any input!
rememeber - i inherited this and would like to make it a lot better than it
is :) thanks sooo much for any input!

-----Original Message-----
From: Ricardo SIGNES [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, October 09, 2002 8:15 AM
To: Jennifer Fountain
Cc: '[EMAIL PROTECTED]'
Subject: Re: help with script


In the future, I think it would be better if you place the script in an
accessible location (WWW) or attached it.  Normally, attachments are bad,
but a
long script with very long lines is worse as a body. 

On Wed, Oct 09, 2002 at 08:01:39AM -0400, Jennifer Fountain wrote:
> I am hoping someone could help me debug a script - I inherited this
script:

I'll try and hit the problem points:

> 
> $MFG_FILE = "manufacturing_order_data_add";
> $ERR_FILE = "manufacturing_order_data_ign";
>

OK, here, these two scalars are populated with filenames as strings.

> open(O1,"> $MFG_FILE") || die "could not open MFG file $!\n";
> open(E1,"> $ERR_FILE") || die "could not open ERR file $!\n";

Now, filehandles O1 and E1 are opened as those handles for writing.  (What
awful filehandle names!)

> #  print O1
>
"MFG-".$key,"\t",$rtng{$key},"\t",$part{$key},"\t",$out_qty{$key},"\t","1","
> \n"; if ($out_qty{$key} ne "0"){    print O1
>
"Z".$ordnbr,"\t",$rtng{$key},"\t",$part{$key},"\t",$out_qty{$key},"\t","0","
> \t","1","\t","1","\n";    $printed{$key}=1; #  }    }

This is the next mention of O1.  Notice that it's commented out.  I'm not
entirely clear on how much of this was commented and how much is not.

> #  print E1 "Total qty for (prt.rtg) = ",$key," , equal to
",$total{$key},"
> not within lot size limits\n";
>    print E1
>
"Z".$ordnbr,"\t",$rtng{$key},"\t",$part{$key},"\t",$total{$key},"\t",$min{$k
> ey},"\n";  }

Same thing, here. 

I'd like to see this file in a pristine state, unmunged by MUAs.  Could you
make it available?
 
> and for some reason - these files - $MFG_FILE =
> "manufacturing_order_data_add"; and $ERR_FILE =
> "manufacturing_order_data_ign"; aren't getting populated with data.  the
> developer thinks this script is the reason but my eyes have looked at this
> too many times to find any errors.

Have you considered whether those files might have been obsoleted by the
command line parameters the script accepts?  I haven't really given it a
thorough look to figure out what it does or what they're for.

-- 
rjbs


begin 600 consolidation.pl
M(R$O=7-R+VQO8V%L+V)I;B]P97)L"B,@4&5R;"!38W)I<'0@9F]R($-O;G-O
M;&ED871I;VX@0V]R<F5C=&EO;B!F;W(@4B9"+"!);F,N"B,@075T:&]R.B!2
M+E-H:79A<F%M86MR:7-H;F%N"B,@0W)E871I;VX@1&%T93H@,3(O,3<O.3@*
M(PH*)$U&1U]&24Q%(#T@(FUA;G5F86-T=7)I;F=?;W)D97)?9&%T85]A9&0B
M.PHD15)27T9)3$4@/2`B;6%N=69A8W1U<FEN9U]O<F1E<E]D871A7VEG;B([
M"@HD1$5,24T])UQT)SL*;W!E;BA2,"PB/"`D05)'5ELP72(I('Q\(&1I92`B
M8V]U;&0@;F]T(&]P96X@0D]-(&9I;&4@)"%<;B(["B-B:6QL7V]F7VUA=&5R
M:6%L<U]D871A"B,@($)I;&Q?3V9?36%T97)I86QS7U)E8V]R9#H*(R`@("`@
M("!P<F]D=6-E9%]P87)T7VYU;6)E<BP@("`@(`HC("`@("`@(')O=71I;F<L
M("`@("`@("`@("`@("`@("`@"B,@("`@("`@8V]N<W5M961?<&%R=%]N=6UB
M97(L("`*(R`@("`@("!C;VYS=6UE9%]Q=6%N=&ET>2P*(PDX(&9I96QD<R!W
M:&EC:"!W92!D;VXG="!N965D(&AE<F4L"B,@("`@("`@;6EN7W%U86YT:71Y
M+`HC("`@("`@(&UU;%]Q=6%N=&ET>2P*(R`@("`@("!M87A?<75A;G1I='D[
M"G=H:6QE*#Q2,#XI>PH@8VAO;7`["B!N97AT(&EF("]>(R\["B!M>2`H)&$L
M)&,L)&0L)&4L)&0Q+"1D,BPD9#,L)&0T+"1D-2PD9#8L)&0W+"1D."PD9BPD
M:"PD9RD@/2!S<&QI="@D1$5,24TI.PHC('!R:6YT("1A+")<="(L)&,L(EQT
M(BPD9BPB7'0B+"1G+")<="(L)&@L(EQN(CL*("1M:6Y[)&$N)&-](#T@)&8[
M"B`D;6%X>R1A+B1C?2`]("1G.PH@)&UU;'LD82XD8WT@/2`D:#L*?0IC;&]S
M92A2,"D@?'P@9&EE(")C;W5L9"!N;W0@8VQO<V4@0D]-(&9I;&4@)"%<;B([
M"@HD1$5,24T])UQT)SL*;W!E;BA2,2PB/"`D05)'5ELQ72(I('Q\(&1I92`B
M8V]U;&0@;F]T(&]P96X@8VUO7VEN='9L(&9I;&4@)"%<;B(["G=H:6QE*#Q2
M,3XI>PH@8VAO;7`["B!N97AT(&EF("]>(R\["B!M>2`H)&$L)&(I(#T@<W!L
M:70H)$1%3$E-*3L*(&EF("@D8B!N92`B(BE["B`@)&-M;U]D871E>R1A?2`]
M("1B.PH@("1I<U]C;VYS>R1A?2`](#$[#0H@?0I]"F-L;W-E*%(Q*2!\?"!D
M:64@(F-O=6QD(&YO="!C;&]S92!C;6]?:6YT=FP@9FEL92`D(5QN(CL*"B1$
M14Q)33TG7'0G.PIO<&5N*%(R+"(\("1!4D=66S)=(BD@?'P@9&EE(")C;W5L
M9"!N;W0@;W!E;B!T;VUO<G)O=R!F:6QE("0A7&XB.PIW:&EL92@\4C(^*7L*
M(&-H;VUP.PH@;F5X="!I9B`O7B,O.PH@;7D@*"1A+"1B*2`]('-P;&ET*"1$
M14Q)32D["B`D5&]M;W)R;W<@/2`D83L*?0IC;&]S92A2,BD@?'P@9&EE(")C
M;W5L9"!N;W0@8VQO<V4@=&]M;W)R;W<@9FEL92`D(5QN(CL*"B1$14Q)33TG
M7'0G.PIO<&5N*%(S+"(\("1!4D=66S-=(BD@?'P@9&EE(")C;W5L9"!N;W0@
M;W!E;B!-1D<@;W5T<'5T(&9I;&4@)"%<;B(["B-M86YU9F%C='5R:6YG7V]R
M9&5R7V]U='!U=`HC("!M;V1E.B!W<FET90HC("!-9F=?3W)D97)?3W5T<'5T
M7U)E8V]R9#H*(PEM9F=?;W)D97(L"B,)<F]U=&EN9RP*(PEP<FEM87)Y7V]U
M='!U=%]P87)T+`HC(`EO=71P=71?<75A;G1I='DL"B,)27-?=&AI<U]7:7`H
M4W1R:6YG*3L*=VAI;&4H/%(S/BE["B!C:&]M<#L*(&YE>'0@:68@+UXC+SL*
M(&UY("@D82PD8BPD8RPD9"PD92D@/2!S<&QI="@D1$5,24TI.PH@:68@*"1E
M(&YE("(Q(BE["B`@)')T9WLD87T])&(["B`@)'!R='LD87T])&,["B`@)'%T
M>7LD87T])&0[#0H@?0I]"F-L;W-E*%(S*2!\?"!D:64@(F-O=6QD(&YO="!C
M;&]S92!-1D<@;W5T<'5T(&9I;&4@)"$@7&XB.PH*)$1%3$E-/2=<="<["F]P
M96XH4C0L(CP@)$%21U9;-%TB*2!\?"!D:64@(F-O=6QD(&YO="!O<&5N(%!3
M5"!F:6QE("0A7&XB.PHC<&QA;FYE9%]S=&%R=%]T:6UE<PHC("!M;V1E.B!W
M<FET90HC("!/<'1I;VYA;#H@5')U90HC("!0;&%N7U)E8V]R9#H*(PEM9F=?
M;W)D97)?:60L"B,);W!E<F%T:6]N7VED+`HC"65P<W1?9F]R;6%T/2)965E9
M34U$1&AH;6US<R(L"B,);'!S=%]F;W)M870](EE965E-341$:&AM;7-S(BP*
M(PEE<'-T+`HC"6QP<W0L"B,)27-?=&AI<U]7:7`H4W1R:6YG*3L*=VAI;&4H
M/%(T/BE["B!C:&]M<#L*(&YE>'0@:68@+UXC+SL*(&UY("@D82PD8BPD8RPD
M9"PD92D@/2!S<&QI="@D1$5,24TI.PHC(&9O<B!D96)U9PHC"7!R:6YT(")%
M;G1E<F5D(&9O<B!M9F<@;W)D97(@(BPD82PB(&9O<B!P87)T("(L("1P<G1[
M)&%]+"(@=VET:"!W:7`@9FEE;&0@/2(L)&4L(EQN(CL*(R!E;F0@9F]R(&1E
M8G5G#0HC(%1H92!N97AT('-T871E;65N="!I9&5N=&EF:65S('1H;W-E('!A
M<G1S('=H97)E(&%T(&QE87-T(&]N92!U;F-O;G-O;&ED871E9"!73R!I<R!N
M;W0@;6%K86)L92X-"B,@268@86QL('5N8V]N<V]L:61A=&5D(%=/)W,@87)E
M(&UA:V%B;&4L('1H96X@9&\@;F]T(&EN8VQU9&4@:6X@=&AE<V4@4$523"!O
M=71P=70@9FEL97,N"B`@:68@*"1D(#P@)&-M;U]D871E>R1P<G1[)&%]?2`F
M)B`D8R`^("1C;6]?9&%T97LD<')T>R1A?7TI>PT*("`@("1O:U]T;U]C;VYS
M>R1P<G1[)&%]?2`](#$[#0H@("!](`T*(&EF("@D92!N92`B,2(I>PHC"7!R
M:6YT(")I<U]C;VYS(#TB+"1I<U]C;VYS>R1P<G1[)&%]?2PB("(L)&$L(B!L
M<'-T(#T@(BPD9"P@(F-M;U]D871E(#T@(BPD8VUO7V1A=&5[)'!R='LD87U]
M+")<;B(["B`@:68@*"1I<U]C;VYS>R1P<G1[)&%]?2`]/2`Q("8F("1D(#P@
M)&-M;U]D871E>R1P<G1[)&%]?2E["B,)<')I;G0@)&$L(B`B+"1C+"(@(BPD
M9"PB("(L)&]K7W1O7V-O;G-[)'!R='LD87U]+"(@8VUO7V1A=&4@/2`B+"1C
M;6]?9&%T97LD<')T>R1A?7TL(EQN(CL-"B`@(&EF("@D97!S='LD87T@97$@
M(B(I>PHC(&9O<B!D96)U9PHC"7!R:6YT(")%;G1E<F5D7&XB.PHC(&5N9"!F
M;W(@9&5B=6<*("`@("1E<'-T>R1A?2`]("1C.PH@("`@<'5S:"A`>R1M9F=S
M>R1P<G1[)&%]+B1R=&=[)&%]?7TL)&$I.PH@("`@)')T;F=[)'!R='LD87TN
M)')T9WLD87U](#T@)')T9WLD87T["B`@("`D<&%R='LD<')T>R1A?2XD<G1G
M>R1A?7T@/2`D<')T>R1A?3L*("`@("1O<F1[)'!R='LD87TN)')T9WLD87U]
M(#T@)&$[#0H@("`@)&]K7W1O7V-O;G-[)'!R='LD87TN)')T9WLD87U](#T@
M)&]K7W1O7V-O;G-[)'!R='LD87U](`T*("`@?0D-"B,@('!R:6YT("1O<F1[
M)'!R='LD87TN)')T9WLD87U]+"(@(BPD<G1N9WLD<')T>R1A?2XD<G1G>R1A
M?7TL(B`B+"1P87)T>R1P<G1[)&%]+B1R=&=[)&%]?2PB("(L)&5P<W1[)&%]
M+"(@(BPD;'!S='LD87TL(EQN(CL-"B`@(&EF("@D8R`\("1E<'-T>R1A?2E[
M"B`@("`D97!S='LD87T@/2`D8SL*("`@?0H@("!I9B`H)&QP<W1[)&%](&5Q
M("(B*7LD;'!S='LD87T@/2`D9#M]"B`@(&EF("@D9"`\("1L<'-T>R1A?2E[
M"B`@("`D;'!S='LD87T@/2`D9#L*("`@?0HC("`@<')I;G0@)&$L(B`B+"1R
M=&YG>R1P<G1[)&%]+B1R=&=[)&%]?2PB("(L)'!A<G1[)'!R='LD87TN)')T
M9WLD87U]+"(@(BPD97!S='LD87TL(B`B+"1L<'-T>R1A?2PB("(L)&]K7W1O
M7V-O;G-[)'!R='LD87U]+")<;B([#0H-"B`@?0H@?0I]"@T*8VQO<V4H4C0I
M('Q\(&1I92`B8V]U;&0@;F]T(&-L;W-E(%!35"!F:6QE("0A(%QN(CL*"F]P
M96XH3S$L(CX@)$U&1U]&24Q%(BD@?'P@9&EE(")C;W5L9"!N;W0@;W!E;B!-
M1D<@9FEL92`D(5QN(CL*;W!E;BA%,2PB/B`D15)27T9)3$4B*2!\?"!D:64@
M(F-O=6QD(&YO="!O<&5N($524B!F:6QE("0A7&XB.PH*9F]R96%C:"`D:V5Y
M("AS;W)T(&ME>7,@)6UF9W,I>PH@0'LD<V]R=&5D7VUF9W-[)&ME>7U](#T@
M<V]R="!B>65P<W0@0'LD;69G<WLD:V5Y?7T["B!F;W)E86-H("1M9F<@*$![
M)'-O<G1E9%]M9F=S>R1K97E]?2E["B`@:68@*"1M9F<@97$@)'LD<V]R=&5D
M7VUF9W-[)&ME>7U]6S!=*7L*("`@)&UI;E]L<'-T>R1K97E](#T@)&QP<W1[
M)&UF9WT["B`@("1O<F1N8G(@/2`D;69G.PT*("!]"B`@:68@*"1L<'-T>R1M
M9F=](#P@)&UI;E]L<'-T>R1K97E]*2!["B`@("1M:6Y?;'!S='LD:V5Y?2`]
M("1L<'-T>R1M9F=].PH@('T*(R`@<')I;G0@)&ME>2PB7'0B+"1M9F<L(EQT
M(BPD97!S='LD;69G?2PB7'0B+"14;VUO<G)O=RPB7'0B+"1M:6Y?;'!S='LD
M:V5Y?2PB7&XB.PH@(&EF("@D97!S='LD;69G?2`\(&UA>"@D5&]M;W)R;W<L
M)&UI;E]L<'-T>R1K97E]*2E["B`@("1T;W1A;'LD:V5Y?2`K/2`D<71Y>R1M
M9F=].PT*("!]"B`@96QS97L*"6QA<W0["B`@("-B<F5A:SL*("!]"B!](`H@
M:68@*"1T;W1A;'LD:V5Y?2!N92`B(B`F)B`D;VM?=&]?8V]N<WLD:V5Y?2`]
M/2`Q*7L*(R`@('!R:6YT(")-1D<M(BXD:V5Y+")<="(L)')T;F=[)&ME>7TL
M(EQT(BPD<&%R='LD:V5Y?2PB7'0B+"1T;W1A;'LD:V5Y?2PB7'0B+"(Q(BPB
M7&XB.PHC('T*(R`@('!R:6YT("1M:6Y[)&ME>7TL(EQT(BPD;75L>R1K97E]
M+")<="(L)&UA>'LD:V5Y?2PB7&XB.PH@)'!R:6YT961[)&ME>7T],#L*(&EF
M("@H)'1O=&%L>R1K97E](#X]("1M:6Y[)&ME>7TI*7L*(&EF("@D;6%X>R1K
M97E](&5Q("(B('Q\("1T;W1A;'LD:V5Y?2`\/2`D;6%X>R1K97E]*7L*("!I
M9B`H)&UU;'LD:V5Y?2$],"E["B,@(&EF("@D=&]T86Q[)&ME>7TE)&UU;'LD
M:V5Y?3T],"E["B,@("`D;W5T7W%T>7LD:V5Y?2`]("1T;W1A;'LD:V5Y?3L*
M("`@)&]U=%]Q='E[)&ME>7T@/2`H:6YT("1T;W1A;'LD:V5Y?2\D;75L>R1K
M97E]*2HD;75L>R1K97E].PHC("!P<FEN="!/,2`B349'+2(N)&ME>2PB7'0B
M+"1R=&YG>R1K97E]+")<="(L)'!A<G1[)&ME>7TL(EQT(BPD;W5T7W%T>7LD
M:V5Y?2PB7'0B+"(Q(BPB7&XB.PT*:68@*"1O=71?<71Y>R1K97E](&YE("(P
M(BE[#0H@("!P<FEN="!/,2`B6B(N)&]R9&YB<BPB7'0B+"1R=&YG>R1K97E]
M+")<="(L)'!A<G1[)&ME>7TL(EQT(BPD;W5T7W%T>7LD:V5Y?2PB7'0B+"(P
M(BPB7'0B+"(Q(BPB7'0B+"(Q(BPB7&XB.PT*("`@)'!R:6YT961[)&ME>7T]
M,3L-"B,@('T-"B`@('T*("!]"B!]"B!]"B!I9B`H)'!R:6YT961[)&ME>7T]
M/3`I('L*("`C('!R:6YT(&]U="!A;B!E<G)O<B!L;V<@<V%Y:6YG('1H870@
M=&]T86P@<71Y(&ES(&QE<W,@=&AA;B!M:6X@;W(*("`C(&=R96%T97(@=&AA
M;B!M87@@<71Y+"!A<R!T:&4@8V%S92!M87D@8F4*(R`@<')I;G0@13$@(E1O
M=&%L('%T>2!F;W(@*'!R="YR=&<I(#T@(BPD:V5Y+"(@+"!E<75A;"!T;R`B
M+"1T;W1A;'LD:V5Y?2PB(&YO="!W:71H:6X@;&]T('-I>F4@;&EM:71S7&XB
M.PH@("!P<FEN="!%,2`B6B(N)&]R9&YB<BPB7'0B+"1R=&YG>R1K97E]+")<
M="(L)'!A<G1[)&ME>7TL(EQT(BPD=&]T86Q[)&ME>7TL(EQT(BPD;6EN>R1K
M97E]+")<;B([#0H@?0H@?0I]"F-L;W-E*$\Q*2!\?"!D:64@(F-O=6QD(&YO
M="!C;&]S92!-1D<@9FEL92`D(5QN(CL*8VQO<V4H13$I('Q\(&1I92`B8V]U
M;&0@;F]T(&-L;W-E($524B!F:6QE("0A7&XB.PH*<W5B(&UA>'L*(&UY("@D
M82PD8BD@/2!`7SL*(&EF("@D82`\/2`D8BD@>W)E='5R;B`D8CM]"B!E;'-E
M('MR971U<FX@)&$[?0I]"@IS=6(@8GEE<'-T>PH@)&5P<W1[)&%](#P]/B`D
-97!S='LD8GT[(`I]"@==
`
end
_______________________________________________
ActivePerl mailing list
[EMAIL PROTECTED]
To unsubscribe: http://listserv.ActiveState.com/mailman/mysubs

Reply via email to