HI Sergio My first pull request ever :-)
Update export.rb #15 Open CCH4GITHUB <https://github.com/CCH4GITHUB> wants to merge 1 commit into naaano:master from CCH4GITHUB:patch-1 +2 −2 Conversation 0 <https://github.com/naaano/active_scaffold_export/pull/15> Commits 1 <https://github.com/naaano/active_scaffold_export/pull/15/commits> Files changed 1 <https://github.com/naaano/active_scaffold_export/pull/15/files> ReviewersNo reviews AssigneesNo one assigned Labels None yet ProjectsNone yet MilestoneNo milestone Notifications Unsubscribe You’re receiving notifications because you authored the thread. 1 participant [image: @CCH4GITHUB] <https://github.com/CCH4GITHUB> Allow edits from maintainers. Learn more [image: @CCH4GITHUB] <https://github.com/CCH4GITHUB> CCH4GITHUB <https://github.com/CCH4GITHUB> commented just now <https://github.com/naaano/active_scaffold_export/pull/15#issue-215240677> Changed before_filter to before_action to comply with DEPRECATED WARNINGS for Rails 5.1 [image: @CCH4GITHUB] <https://github.com/CCH4GITHUB> Update export.rb <https://github.com/naaano/active_scaffold_export/pull/15/commits/f35779fc0e560670995bdb5fde2a46caca6f84e7> … On Thursday, March 16, 2017 at 6:21:37 PM UTC+8, Sergio Cambra wrote: > > You can edit lib/active_scaffold/actions/export.rb in github, change > before_filter with before_action and send pull request > > El jueves, 16 de marzo de 2017 10:30:24 (CET) Chee Chong Hwa escribió: > > Hi Sergio > > > > No place to open issue at > https://github.com/naaano/active_scaffold_export > > > > :-( > > > > On 15 March 2017 at 21:32, Sergio Cambra <[email protected] > <javascript:>> wrote: > > > master branch of ActiveScaffold doesn't use before_filter anymore, > line 47 > > > of > > > core.rb is including an action module, I guess export action from > > > active_scaffold_export, which still uses before_filter. > > > > > > You should open issue in > https://github.com/naaano/active_scaffold_export > > > asking for replacing before_filter with before_action > > > > > > El miércoles, 15 de marzo de 2017 11:45:47 (CET) Chee Chong Hwa > escribió: > > > > Hi Sergio > > > > > > > > I am using Rails 5.01 and just upgraded to 5.02 > > > > > > > > Do you need to update Active_Scaffold and Active_Scaffold_Export to > > > > > > remove > > > > > > > the DEPREATION warnings? > > > > > > > > Started GET "/tasks" for ::1 at 2017-03-15 18:38:25 +0800 > > > > > > > > DEPRECATION WARNING: before_filter is deprecated and will be removed > in > > > > Rails 5. > > > > 1. Use before_action instead. (called from include at > > > > C:/RailsInstaller/Ruby2.2. > > > > 0/lib/ruby/gems/2.2.0/bundler/gems/*active_scaffold* > > > > -d5b305a1d797/lib/active_scaff > > > > old/core.rb:47) > > > > > > > > DEPRECATION WARNING: before_filter is deprecated and will be removed > in > > > > Rails 5. > > > > 1. Use before_action instead. (called from included at > > > > C:/RailsInstaller/Ruby2.2 > > > > .0/lib/ruby/gems/2.2.0/bundler/gems/*active_scaffold_export* > > > > -f143753f7979/lib/acti > > > > ve_scaffold/actions/export.rb:4) > > > > > > > > DEPRECATION WARNING: before_filter is deprecated and will be removed > in > > > > Rails 5. > > > > 1. Use before_action instead. (called from included at > > > > C:/RailsInstaller/Ruby2.2 > > > > .0/lib/ruby/gems/2.2.0/bundler/gems/*active_scaffold_export* > > > > -f143753f7979/lib/acti > > > > ve_scaffold/actions/export.rb:5) > > > > > > > > Cheers :-) > > > -- You received this message because you are subscribed to the Google Groups "ActiveScaffold : Ruby on Rails Gem" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/activescaffold. For more options, visit https://groups.google.com/d/optout.
