On Thu, Feb 6, 2014 at 8:43 PM, Yuri Gribov <[email protected]> wrote:
> Cool! My comments below. > > > Smaller disk usage > > How about "Smaller memory footprint"? > Done. > > > __asan_init is not called from preinit_array and so there is a risk that > an instrumented code will get called before __asan_init > > 1) Should probably decribe symptoms here (call to NULL). > We tried to eliminate all such failures and we don't know of any existing one. Added "(may cause SEGV at startup; still unlikely)" 2) Can we add a check to REAL() to produce a nice diagnostic message > in this case? > There are a few such checks. > 3) We once discussed making __asan_init a constructor to solve this > problem (discussion and patch available here: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58937). > __asan_init is a constructor, but there could be other constructors that run before it. > > > the binary is linked against incompatible DSO version > > Nice one. I wonder whether we can catch this in preloaded libasan > (e.g. search for all older __asan_init_vXXX using dlsym at start). > This should be detected at load time precisely due to __asan_init_vXXX mismatch. > > >> There are some bugs specific to using asan as a shared library, e.g. > > Can you add other bugs as well? > When I find/remember them. I afraid we did not document all of the cases like this yet because we have very little experience with dynamic run-time on linux. > > Some proposal from me: > * could you add a note about spurious "failed to intercept" warnings? > (see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58680 for reference) > Hm? What about that? How would you phrase it? > > BTW should we acronimize as ASAN or ASan? > Emm. I equally like all of {asan,ASAN,ASan} and I don't care much. --kcc > > -Y > > -- > You received this message because you are subscribed to the Google Groups > "address-sanitizer" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "address-sanitizer" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
