I'm aware of that! I'm just suggesting to ifdef two VC-specific lines of code.
On Saturday, November 8, 2014 12:32:48 AM UTC+3, kcc wrote: > > > > On Fri, Nov 7, 2014 at 1:13 PM, Constantine Tarasenkov <[email protected] > <javascript:>> wrote: > >> If you are using mingw, we can assume they won't be called. >>> >> Linker gives me error because it can't find these symbols, it should be >> ifdef'ed with _MSC_VER otherwise user is forced to link against >> msvcrt40.dll. >> >> However, so far as I know nobody has been testing ASan on Windows with >>> anything over than MSVC and Clang, so this would all be new territory. >> >> Since you guys contributing windows related code to GCC, you can expect >> to see more people like me who will try to use GCC on Windows :) >> > > We are working on Clang+ASan on windows, but not on GCC on Windows. > > >> >> On Wednesday, November 5, 2014 9:15:09 PM UTC+3, Reid Kleckner wrote: >>> >>> ASan doesn't depend on those symbols, it's merely trying to intercept >>> them in case they ever get called. If you are using mingw, we can assume >>> they won't be called. An ifdef, or something cleaner, would probably be >>> appropriate. However, so far as I know nobody has been testing ASan on >>> Windows with anything over than MSVC and Clang, so this would all be new >>> territory. >>> >>> On Wed, Nov 5, 2014 at 3:16 AM, Constantine Tarasenkov <[email protected] >>> > wrote: >>> >>>> This code: >>>> https://github.com/gcc-mirror/gcc/blob/141eb62b/libsanitizer/asan/asan_ >>>> interceptors.cc#L721-L722 >>>> >>>> Depends on VIsual C++ specific library called msvcrt40.dll, which is >>>> not available in MinGW or MinGW-w64. I know it doesn't tested yet to work >>>> with these compilers, but I'm not sure under which license msvcrt40.dll is >>>> distributed, where I should get it and will it be legal to download it >>>> from >>>> Internet and distribute with my programs. >>>> >>>> If it means that no one will be able to compile asan for windows >>>> without Visual C++ runtime library, I'll find it funny because we're >>>> talking about GCC :) Maybe it should be enclosed in MSVC specific ifdef's >>>> or something? >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "address-sanitizer" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "address-sanitizer" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "address-sanitizer" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
