On Thu, Jan 22, 2015 at 1:39 PM, 'Evgeniy Stepanov' via address-sanitizer <[email protected]> wrote: > On Thu, Jan 22, 2015 at 1:12 PM, 'Dmitry Vyukov' via address-sanitizer > <[email protected]> wrote: >> On Thu, Jan 22, 2015 at 1:01 PM, 'Evgeniy Stepanov' via >> address-sanitizer <[email protected]> wrote: >>> Hi, >>> >>> at the moment we add __interceptor_xxx (for all intercepted functions) >>> to the runtime library dynamic list, along with xxx themselves. This >>> (a) seems to confuse the symbolizer sometimes (it would say that the >>> memory was allocated in __interceptor_malloc which is suboptimal) >>> (b) slows down program startup (I don't have any numbers though) >>> >>> I don't see why we need to export __interceptor_xxx. It does not look >>> like they are called by that name anywhere. Disabling this (a >>> one-liner in gen_dynamic_list.py) does not break any tests. >>> >>> Am I missing anything? >> >> >> We do call interceptors by that name in few places in our internal code base. > > Yeah, sometimes we do need to know that we are calling the > interceptor, and not the libc function. > >> >> Also, if you remove them, then symbolizer won't be able to print >> anything at all, which does not look better. > > No, we have 2 exported symbols: xxx and __interceptor_xxx, the > proposal was to remove the second one.
User can override any interceptor. Then the only name of an interceptor is __interceptor_xxx. >> Btw, tsan strips __interceptor_ prefixes. Which is actually another >> use of __interceptor_ symbols. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "address-sanitizer" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups > "address-sanitizer" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "address-sanitizer" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
