Thanks, I'll send a patch for review. Kuba
> On Nov 29, 2017, at 9:25 PM, 'Dmitry Vyukov' via address-sanitizer > <[email protected]> wrote: > > On Thu, Nov 30, 2017 at 4:55 AM, Kuba Mracek <[email protected]> wrote: >> Hi! >> >> On Linux, Does MADV_DONTNEED (used in ReleaseMemoryPagesToOS) actually mark >> the pages as free to be overwritten with zeroes? > > Yes, on linux it works as intended. > > >> It seems that the POSIX >> explanation of POSIX_MADV_DONTNEED means something different ("the system >> can page the memory out, but not discard the content"). Darwin and BSD >> understand MADV_DONTNEED in the POSIX sense, which means that >> ReleaseMemoryPagesToOS doesn't really release any memory on those systems. >> Does it make sense to use some other mechanism of releasing the pages? > > On darwin/bsd we should use MADV_FREE instead. > > -- > You received this message because you are subscribed to the Google Groups > "address-sanitizer" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "address-sanitizer" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
