On Sun, 2006-12-03 at 15:13 +0100, Jan Kiszka wrote:
> Hi,
>
> I came across a few things in latest 2.6.19-i386-1.6-01 patch:
>
> The usage of __ipipe_pipelock in __ipipe_common_info_proc is broken (raw lock
> used as
> Linux lock here), and I do not see any volatile data it could protect anyway.
> So let's
> remove it.
The interrupt status word, and whether any virtual interrupt is
allocated or not, are the volatile data protected by this lock on a SMP
system. Since this is a common spinlock with no interrupt control
required which is only used over the Linux domain (/proc handler), you
don't need to go for the _hw() form of it.
[...]
>
> The hard IRQ state of the tracer output got inverted during recent
> restructuring. This
> fixes it (and indents a few labels correctly).
>
Ack. Merged.
[...]
> And finally, ipipe_init_proc can be moved to the __init section.
>
> --- linux-2.6.19-ipipe.orig/kernel/ipipe/core.c
> +++ linux-2.6.19-ipipe/kernel/ipipe/core.c
> @@ -1362,7 +1362,7 @@ void __ipipe_remove_domain_proc(struct i
> remove_proc_entry(ipd->name,ipipe_proc_root);
> }
>
> -void ipipe_init_proc(void)
> +void __init ipipe_init_proc(void)
> {
> ipipe_proc_root = create_proc_entry("ipipe",S_IFDIR, 0);
>
> create_proc_read_entry("version",0444,ipipe_proc_root,&__ipipe_version_info_proc,NULL);
>
Ack. Merged.
>
>
> There is more cleanup stuff in my pipe, one of it (type-based spinlock
> selection)
> could be helpful for follow-up work on other archs. It's almost done, I will
> try to
> prepare patch series over the next days.
Thanks.
--
Philippe.
_______________________________________________
Adeos-main mailing list
[email protected]
https://mail.gna.org/listinfo/adeos-main
