Gilles Chanteperdrix wrote: > Jan Kiszka wrote: >> Jan Kiszka wrote: >>> ... >>> However, let's assumed we entered __ipipe_syscall_root with root domain >>> stalled. If we then return from __ipipe_dispatch_event with 0 (=> >>> forward this syscall to Linux), we would not call __fixup_if again so >>> that the stalled state is kept. Is this a valid scenario for the given >>> task, or would this be broken already? At least it looks like the path >>> taken here >> Could someone explain __ipipe_syscall_root to me? The comment before the >> second __fixup_if() does not help me understanding why we only have to >> call it when we do not forward the syscall to Linux. In other words, >> this version would make more sense to me (32-bit variant, but 64-bit >> looks as fishy as its little brother): > > My understanding is that we should call fixup_if again if we changed > domain while handling the syscall.
Yep, but does this derive indirectly from the return code of __ipipe_dispatch_event? AFAIU, it shouldn't, so we should fix up unconditionally if we entered the dispatcher. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux _______________________________________________ Adeos-main mailing list [email protected] https://mail.gna.org/listinfo/adeos-main
