much nicer to the users. I like it
On 7/6/06, Adam Winer <[EMAIL PROTECTED]> wrote:
-1; instead, we should append a ":" if it isn't already the last character. -- Adam On 7/6/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > Trust me guy, > > there are always some thing you never expected :-) > > (as mentioned in the JIRA, please use a SVN dif in future ;)) > > -Matt > > On 7/6/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> > wrote: > > +1 for the IllegalArgumentException > > > > I never tought about that when writting the patch... being to "used" in > > assuming the user whould be aware of what he's doing and so, should be > > using the program in the normal way with always valids arguments ! > > > > [EMAIL PROTECTED] a écrit sur 2006-07-06 12:55:58 : > > > > > I am testing this patch now. > > > > > > One thing that came up was, what todo, when a user not provides a ":" > > > > > > like > > > > > > <context-param> > > > <param-name>org.apache.myfaces.adf.DIALOG_NAVIGATION_PREFIX > </param-name> > > > <param-value>userInputHere</param-value> > > > </context-param> > > > > > > I am +1 on throwing an IllegalArgumentException. > > > > > > WDYT ? > > > > > > -Matt > > > > > > > > > -- > > > Matthias Wessendorf > > > > > > futher stuff: > > > blog: http://jroller.com/page/mwessendorf > > > mail: mwessendorf-at-gmail-dot-com > > > > > > > -- > Matthias Wessendorf > > futher stuff: > blog: http://jroller.com/page/mwessendorf > mail: mwessendorf-at-gmail-dot-com >
-- Matthias Wessendorf futher stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
