A new shuttle renderer would be a biiiiig improvement... I think a lot of code is mostly still necessary because of that one renderer.
BTW, if you run the build in Maven after deleting something like IconRenderer, you'll get a failure running the CoreRenderKitTest; so even though this class is dynamically loaded, there's good safeguards in place to make sure we won't delete anything that is still used. -- Adam On 9/12/06, Simon Lessard <[EMAIL PROTECTED]> wrote:
Good to know, I'll add that renderer on the TODO list. I think there's also the processChoiceBar that need one. On 9/12/06, Jeanne Waldman <[EMAIL PROTECTED]> wrote: > > I see now what the old IconRenderer is used for; the shuttle renderers > are not > yet faces-major and they use the old IconRenderer code. > > Simon Lessard wrote: > > > We have many old renderers in the ui package system that are not used > > anymore and could be cleared, but I don't know if adam want to do that > > already. I guess you could delete it if it prevents compilation, else it > > don't hurt to stay there until we kill the whole package tree, or at > > least > > until Adam is back. > > > > > > Regards, > > > > ~ Simon > > > > On 9/6/06, Jeanne Waldman <[EMAIL PROTECTED]> wrote: > > > >> > >> Does anyone know why we have 2 IconRenderers... one in > >> org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml; (non Faces-major > >> package) > >> > >> and one in > >> package org.apache.myfaces.trinidadinternal.renderkit.core.xhtml; > >> (Faces-major package) > >> > >> I can't tell if the non-Faces-major one is being used anywhere. > >> > >> Can I delete the non-Faces-major one? > >> > >> Thanks, > >> Jeanne > >> > >> > >> > > > >
