We'll have to check if overloading works with varargs before applying that change then.
On 9/27/06, Adam Winer <[EMAIL PROTECTED]> wrote:
Simon, We should keep an ordinary String renderStyleClass() API, because the one-element case is so common. I don't want to force everything through the varargs bottleneck, which will allocate *a lot* of unnecessary one-element arrays. -- Adam On 9/27/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > yeah, forgot that discussion from you ;) > > thanks! > > On 9/27/06, Simon Lessard <[EMAIL PROTECTED]> wrote: > > Yes and no, > > > > If we add varargs, it will always be an array, even when you send a single > > String, so one element String will actually be decently common. > > > > On 9/27/06, Adam Winer <[EMAIL PROTECTED]> wrote: > > > > > > Weeelll... I wonder whether this is actually an optimization, > > > because who would ever call renderStyleClasses() with > > > a one-element array? If no one ever does that, then this > > > in fact makes the code a bit slower. > > > > > > -- Adam > > > > > > > > > On 9/27/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > > > Any objects regarding [1] > > > > > > > > [1] https://issues.apache.org/jira/browse/ADFFACES-203 > > > > > > > > -- > > > > Matthias Wessendorf > > > > http://tinyurl.com/fmywh > > > > > > > > further stuff: > > > > blog: http://jroller.com/page/mwessendorf > > > > mail: mwessendorf-at-gmail-dot-com > > > > > > > > > > > > > > -- > Matthias Wessendorf > http://tinyurl.com/fmywh > > further stuff: > blog: http://jroller.com/page/mwessendorf > mail: mwessendorf-at-gmail-dot-com >
