I commented the JIRA, but in case you filter it out... I have a comment:
I made the changes, and I was about to commit, when I saw a problem with using
-tr-. I saw this skin property:
"af|treeTable-tr-spacer-width";, and I thought, oh, they put html implementation detail into the
skin property. That's not good. Then a second later, I woke up and realized that I had just changed it from
"af|treeTable-ora-spacer-width" to "af|treeTable-tr-spacer-width";
Anyone else think the same thing? I'm wondering if we should use -trd- or -trn-
instead.
public static final String AF_PANELHEADER_INDENT_CONTENT =
"af|panelHeader-tr-indent-content";
public static final String AF_PANEL_BORDER_LAYOUT_SPACER_WIDTH =
"af|panelBorderLayout-tr-spacer-width";
public static final String AF_PANEL_LIST_DEFAULT_COLUMNS =
"af|panelList-tr-default-columns";
public static final String AF_TABLE_REPEAT_CONTROL_BAR =
"af|table-tr-repeat-control-bar";
public static final String AF_TABLE_SELECTION_BAR_IN_TABLE =
"af|table-tr-selection-bar-in-table";
public static final String AF_TRAIN_RENDER_PARENT_TRAIN =
"af|train-tr-render-parent-train";
public static final String AF_TRAIN_VISIBLE_STOP_COUNT =
"af|train-tr-visible-stop-count";
public static final String AF_TREE_TABLE_SPACER_WIDTH =
"af|treeTable-tr-spacer-width";
Adam Winer wrote:
I think I'd prefer -tr- to -tri-
-- Adam
On 9/15/06, Simon Lessard <[EMAIL PROTECTED]> wrote:
Hello all,
As Gabrielle raised, tri sounds a bit like three, should we use -tr-
instead
to be consistent with our other changes?
Regards,
~ Simon
---------- Forwarded message ----------
From: Jeanne Waldman (JIRA) <[email protected]>
Date: Sep 14, 2006 5:51 PM
Subject: [jira] Commented: (ADFFACES-56) change -ora-* skinning
properties
to have another prefix
To: [email protected]
[
http://issues.apache.org/jira/browse/ADFFACES-56?page=comments#action_12434825]
Jeanne Waldman commented on ADFFACES-56:
----------------------------------------
Have we decided that -tri- is what we want?
> change -ora-* skinning properties to have another prefix
> --------------------------------------------------------
>
> Key: ADFFACES-56
> URL: http://issues.apache.org/jira/browse/ADFFACES-56
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Jeanne Waldman
>
> The -ora- prefix needs to be changed.
> Suggestions:
> -oam- (for org apache myfaces)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
