+1 as well, when I first saw that method I thought about money.
On 10/25/06, Adam Winer <[EMAIL PROTECTED]> wrote:
+1 for me - I've always found the word "currency" to be incredibly confusing. -- Adam On 10/24/06, Arjuna Wijeyekoon <[EMAIL PROTECTED]> wrote: > Hi, > Currently UIXCollection has the following methods: > public String getCurrencyString() > public void setCurrencyString(String currency) > protected void clearCurrencyStringCache() > > > Now that issue 210 (http://issues.apache.org/jira/browse/ADFFACES-210) has > been implemented > and we have a ClientRowKeyManager class that handles the > object-rowkey->string-key mapping, I'd like to propose the following > changes: > 1. rename get/setCurrentString to get/setClientRowKey > 2. remove the clearCurrencyStringCache method (ie: make it package-private). > > what do you think? > > If we do decide to implement these changes, I'd like to do them in two > parts: > 1. first add the new methods and deprecate the old ones. > 2. give a few days for dependent projects to upgrade and then remove the old > deprecated methods. > > is that ok? > > thanks > Arjuna > >
