Yeah that would be a good idea. On 11/9/06, Adam Winer <[EMAIL PROTECTED]> wrote:
I agree, it'd be good to fix all those. -- Adam On 11/8/06, Arjuna Wijeyekoon <[EMAIL PROTECTED]> wrote: > The public class: > org.apache.myfaces.trinidad.util.Base64OutputStream > > is annoying me. > > 1. it has a finish() method instead of a close() method. > 2. it doesn't have a close() method at all. It should have one that > delegates to the > underlying Writer > 3. it doesn't have a flush() method that delegates to the underlying writer. > > I think we should fix these issues before we have a public release. > is it ok if I file a JIRA? > > --arjuna >
