Well a patch is not mandatory, since open source is volunteer driven, but that definitely speeds up things ... :)
On 11/22/06, Piyush Hari <[EMAIL PROTECTED]> wrote:
you'l have to provide a patch file at that Jira once you are done with removing it.That will be reviewed by the commiters and included in the code. -Piyush ----- Original Message ----- From: "Qiang Fan" <[EMAIL PROTECTED]> To: <[email protected]> Sent: Wednesday, November 22, 2006 10:27 AM Subject: Re: Remove maximumLength attribute from inputDate > An issue has already been opened in jira. The key number is > ADFFACES-300<http://issues.apache.org/jira/browse/ADFFACES-300>. > Is there any thing else I need to do? > > Thanks. > > John > > > On 11/20/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: >> >> same here. >> >> can you open a ticket on jira for that? >> >> On 11/21/06, Gabrielle Crawford <[EMAIL PROTECTED]> wrote: >> > +1. The converter understands strings of a certain format. Anything >> > longer or shorter will give an error. I can't see how maximumLength is >> > useful on inputDate. >> > >> > Thanks, >> > >> > Gab >> > >> > Qiang Fan wrote: >> > >> > > Hi! >> > > >> > > InputDate component has an maximumLength attribute that specifies the >> > > maximum number of characters that can be entered into the edit field. >> > > >> > > Unlike inputText, inputDate will always have a converter (if the page >> > > does >> > > not specify, it has its default converter). Since the converter in >> > > inputDate >> > > can already ensure the maximum length of the string entered, the >> > > maximumLength attribute is not necessary. It should be removed from >> > > the API. >> > > >> > > Thanks. >> > > >> > > John Fan >> > > >> > >> > >> >> >> -- >> Matthias Wessendorf >> http://tinyurl.com/fmywh >> >> further stuff: >> blog: http://jroller.com/page/mwessendorf >> mail: mwessendorf-at-gmail-dot-com >> >
-- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
