Hello Martin, thanks for valuable feedback, appreciate that.
See inline for some comments On 1/16/07, Martin van den Bemt <[EMAIL PROTECTED]> wrote:
Hi people, Just was checking the plugins release and I noticed a couple of things that could be improved (this is not specifically about the release, but more technical). A couple of things were missing from the release, which could be handled a different way : - The parent pom of trinidad plugins could org.apache/apache/3 (think that is ) This fixes the license things automatically.
done, uploading the new homepage later today
- if you put a NOTICE.txt and LICENSE.txt in every "root" of an artifact (plugins can be used individually, so I think they need to be there anyway), you can simply use the resources plugin to include them from the root of the plugin, instead of having them in src/main/resources. In any case, the NOTICE could be different for every plugin (eg could imagine adding javacc to the notice of the javacc plugin)
I used <resources> plugin to archive that; for javacc I added Sun's BSD-style license to our license txt as well; also I added a comment to the notice.txt file the incubator_notice.txt is now also part of meta-inf folder.
- The current signing of the plugin (when doing releases) is uncommented. You can also put that in a profile, so you don't have to change the pom each time (probably could also be done in a profiles.xml, but to be honest, I never used that)
is that really a show stopper ? other podlings aren't doing this as well; currently it is only me doing the release or trying to (only my gpg-key part of KEYS file)
- Add some documentation how a release are made by the trinidad project (also for the non plugin releases). (if it is already there, sorry didn't look too close :)
what do you mean? We have a wiki page, containing some infos on the release (fixed issues etc)
If I can find some time I can do some of the changes myself and send patches / commit myself (whatever is preferred, in the commit myself scenario I will give myself karma for trinidad). I can also do it in a branch, so you can review if you are happy with the changes I have in mind..
Go ahead and yourself karma for trinidad. Also I don't mind if you work on my "matzew-m1-plugins" branch. As mentioned, I already addressed lot's of the issues One more thing from my side to you as a mentor: I already did a vote thread here in trinidad, should I do a CC to your private email address to ensure that a vote like this is on your radar ? ;) Thanks again for taking the time to help/guide us. mfg, Matthias
Mvgr, Maritn
-- Matthias Wessendorf http://tinyurl.com/fmywh further stuff: blog: http://jroller.com/page/mwessendorf mail: mwessendorf-at-gmail-dot-com
