[ http://issues.apache.org/jira/browse/ADFFACES-44?page=comments#action_12420339 ]
Adam Winer commented on ADFFACES-44: ------------------------------------ Minor comments and questions on the patch: - In general, avoid reformatting files when submitting patches; it makes it far more time consuming to review the patch. - Specifically, in: - public void validate( - FacesContext context, - UIComponent component, - Object value - ) throws ValidatorException + public void validate(FacesContext context, UIComponent component, Object value) + throws ValidatorException .... the old formatting is preferred. - getNoMatchMessageDetailNoEval() does not need to be protected, so it should be private. (General coding rule for Trinidad - nothing should be protected unless it absolutely is required by subclasses.) > <af:validateRegExp/> does not allow EL for noMatchMessageDetail > --------------------------------------------------------------- > > Key: ADFFACES-44 > URL: http://issues.apache.org/jira/browse/ADFFACES-44 > Project: MyFaces ADF-Faces > Type: Bug > Reporter: Simon Lessard > Attachments: RegExpValidatorEL.patch > > I copied this bug from OTN at > http://forums.oracle.com/forums/message.jspa?messageID=1355472#1355472 > You cannot specify a noMatchMessageDetail using EL pointing on a resource > file when using the <af:validateRegExp/> tag. > The reproduction case is: > [code] > <f:loadBundle basename="some.resource.file" var="res"/> > <af:inputText> > <af:validateRegExp pattern="\w*" > noMatchMessageDetail="#{res['some.key']]}"/> > </af:inputText> > [/code] -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
