[ http://issues.apache.org/jira/browse/ADFFACES-68?page=comments#action_12425018 ] Adam Winer commented on ADFFACES-68: ------------------------------------
The attributes should be named borderWidth, frameBorderWidth, and frameSpacing, and be integers, not booleans. Also, instead of patching FrameBorderLayoutRenderer, there should be a new "faces-major" renderer... So, -1 on applying this patch as is. > remove frameset border in afh:frameBorderLayout > ----------------------------------------------- > > Key: ADFFACES-68 > URL: http://issues.apache.org/jira/browse/ADFFACES-68 > Project: MyFaces ADF-Faces > Issue Type: Improvement > Reporter: Arnaud MERGEY > Priority: Minor > Attachments: FrameBorderLayoutRenderer.java, > FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, > HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, > withBorder.JPG, withoutBorder.JPG > > > In pages I need to remove frameset border with framespacing and border > parameter (ex:<frameset framespacing="0" border="0" frameborder="0">). > I have hard coded in FrameBorderLayoutRenderer.java > //XXX AM:disable frameset border > writer.writeAttribute("framespacing", "0", null); > writer.writeAttribute("border", "0", null); > writer.writeAttribute("frameborder", "0", null); > It would be fine to add a parameter in afh:frameBorderLayout to allow > conditional removing of frameset border -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
