[ http://issues.apache.org/jira/browse/ADFFACES-72?page=comments#action_12425036 ] Adam Winer commented on ADFFACES-72: ------------------------------------
Applied patch, mostly. There were a few locations where indexed-for-loops were undesirably converted to the JDK 1.5 form. Also, I did not apply the serialVersionUID additions (not a part of Java 5 standards), something that should be discussed before we add it. @Simon: There were also some other changes made in this patch that should not have been, including ADFFACES-73 and changes to resource loading. It makes it much harder to review patches like this or track down any future bugs. It's a pain, but please stick to one patch for one issue. > Convert Trinidad to Java 5 standards and clean-up code > ------------------------------------------------------ > > Key: ADFFACES-72 > URL: http://issues.apache.org/jira/browse/ADFFACES-72 > Project: MyFaces ADF-Faces > Issue Type: Improvement > Reporter: Simon Lessard > Priority: Minor > Attachments: API_1_5_standard.zip > > > This is a non critical long term improvement that should convert existing > Trinidad code to Java 5.0 standard: > - Remove references to deprecated API > - Remove unused imports > - Remove unread variables > - Change StringBuffer to StringBuilder where synchronization is not required > - Reduce to minimum the use of raw type collections (they should be used only > when calling an external 1.4 API) > - Make all collection generic compliant > - Use the enhanced 'for' construct in favor to classical 'for' whenever > possible to reduce potential OutOfBoundsException risks > - Use enums > - Use concurrent API > - Add @Override annotation on overridden methods > - Add @SuppressWarning("unchecked") on method calling external method that > returns non-generic enabled collections -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
