[ http://issues.apache.org/jira/browse/ADFFACES-124?page=all ]
Simon Lessard updated ADFFACES-124:
-----------------------------------
Attachment: ADFFACES-124_phase_1.patch
This patch remove all direct dependancies between the new renderkit package
structure and the UIConstants and XhtmlLafConstants interfaces.
By direct I mean that it's still possible that some classes implements the
latter two through another class/interface they extend/implement. Such
transitive dependancies have already be resolved for BaseDesktopConstants and
such though.
Only the constants really used in the renderkit structure were copied to the
new interfaces. Two interfaces were created for this patch, XhtmlConstants
extending both: SkinSelectors and SkinProperties. The former contains all skin
selectors used by the renderkit package system (unless there's transitive usage
that has yet to be discovered) while the latter contains valid skin properties
such as af|breadCrumbs-ora-show-last-item.
This is the first phase of applying coding conventions to the new package
structure, the following are:
1. Make XhtmlConstants an uninstanciable class implementing SkinSelectors and
SkinProperties. This will allow to detect all classes formerly implementing
XhtmlConstants and change their constant usage to XhtmlConstant.MY_CONSTANT
2. Make SkinProperties an uninstanciable class and remove inheritance between
XhtmlConstants and SkinProperties.
3. Make SkinSelectors an uninstanciable class and remove inheritance between
XhtmlConstants and SkinSelectors.
Note: This patch include the previous one so the former one does not need to be
used.
> Move relevant constants from UIConstants and XhtmlLafConstants to
> XhtmlConstants
> --------------------------------------------------------------------------------
>
> Key: ADFFACES-124
> URL: http://issues.apache.org/jira/browse/ADFFACES-124
> Project: MyFaces ADF-Faces
> Issue Type: Task
> Components: Build
> Reporter: Simon Lessard
> Priority: Minor
> Attachments: ADFFACES-124_phase_1.patch,
> ADFFACES-124_UIConstants.patch
>
>
> This is the first part of constants refactoring that can be done in three
> steps:
> 1) Identify constants from
> org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml.XhtmlLafConstants and
> org.apache.myfaces.trinidadinternal.ui.UIConstants that are used by renderers
> in the new faces major versions.
> 2) Moves those constants to
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlConstants.
> 3) Remove the extends from
> org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlConstants
> interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
