[ http://issues.apache.org/jira/browse/ADFFACES-142?page=comments#action_12429731 ] Simon Lessard commented on ADFFACES-142: ----------------------------------------
Hello Sylvain, Thanks for your interest in Trinidad. There's some things that need to be done with your patch before we can consider it: 1. Can you attach a new patch including the new files please? You can do this using SVN add, it won't require you to have write access. After the addition is flagged, you can create the patch file that will include the new files. 2. We cannot use the patch if you don't grant ASF license to your files, so please grant it when you attach the patch. 3. Please flag the issue as "Patch provided" once the above is done. Else it's hard to track what issues actually have a patch attached to them. Thanks, ~ Simon > More config Options > ------------------- > > Key: ADFFACES-142 > URL: http://issues.apache.org/jira/browse/ADFFACES-142 > Project: MyFaces ADF-Faces > Issue Type: New Feature > Components: Plugins > Reporter: Sylvain Deschênes > Priority: Minor > Attachments: Dependency.java, newFeature, RunConfiguration.java > > > One of our developer was tired of always specifying options, so we made some > changes to the plugin. > With this, you can specify in your pom some Run/Debug configuration. If the > configuration didn't exist, it will create it. Here's an example: > <configuration> > <runConfigurations> > <runConfiguration> > <name>Default</name> > > <targetURL>src/main/webapp/index.jsp</targetURL> > <vMName>Server</vMName> > > <programArguments>-Dbla.bla=somevalue</programArguments> > </runConfiguration> > <runConfiguration> > <name>Test</name> > > <programArguments>-Dtest=test</programArguments> > </runConfiguration> > </runConfigurations> > </configuration> > Another thing we changed is let you the user provide an exclusion list of > dependencies. Our jsp files are compiled with the jspc-maven-plugin who need > jasper-runtime dependency. But when you're in JDeveloper, I don't want to use > jasper-runtime, I want to let JDev compile the jsp. So i need to remove it. > Now you can do it in your pom file with: > <configuration> > <exclusionDependencies> > <dependency> > > <groupId>tomcat</groupId> > > <artifactId>jasper-runtime</artifactId> > </dependency> > </exclusionDependencies> > </configuration> > You can remove any dependencies, not only jasper-runtime. Don't know if it's > the best way but we tried the exclusion with the scope parameter, but some > libraries where still needed in JDev, so we choose to do it this way. > With the same idea (wich is letting JDeveloper compile the jsp) I had a new > configuration option to remove the pre-compiled jsp (.java file) from the > source path. By default, all the jsp are removed, but if you really need them > you could use this config option: > <configuration> > > <removeJspSource>false</removeJspSource> > </configuration> > I've also included a fix for my last patch. I didn't notice that I was using > the name of the j2eeWebApp in two projects within the same workspace, > something that JDeveloper doesn't like. So this file include all my last > patch and the new features. > For doing this new features, I need 2 more classes provided here. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
